drivers: gpio: amd8111: prefer dev_err()/dev_info() over raw printk
authorEnrico Weigelt, metux IT consult <info@metux.net>
Thu, 3 Dec 2020 18:24:22 +0000 (19:24 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 8 Dec 2020 08:41:32 +0000 (09:41 +0100)
For logging in device contexts, dev_*() functions are preferred over
raw printk(), which also print out device name.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Link: https://lore.kernel.org/r/20201203182423.5499-2-info@metux.net
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-amd8111.c

index fdcebe59510dd798c651993a4b805439cdd7a2b1..0e260950992dd05541fc4163cb064324f81228e4 100644 (file)
@@ -179,7 +179,6 @@ static int __init amd_gpio_init(void)
        struct pci_dev *pdev = NULL;
        const struct pci_device_id *ent;
 
-
        /* We look for our device - AMD South Bridge
         * I don't know about a system with two such bridges,
         * so we can assume that there is max. one device.
@@ -223,11 +222,10 @@ found:
 
        spin_lock_init(&gp.lock);
 
-       printk(KERN_INFO "AMD-8111 GPIO detected\n");
+       dev_info(&pdev->dev, "AMD-8111 GPIO detected\n");
        err = gpiochip_add_data(&gp.chip, &gp);
        if (err) {
-               printk(KERN_ERR "GPIO registering failed (%d)\n",
-                      err);
+               dev_err(&pdev->dev, "GPIO registering failed (%d)\n", err);
                ioport_unmap(gp.pm);
                goto out;
        }