iommu/mediatek: Fix error code in probe()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 5 Feb 2021 12:46:17 +0000 (15:46 +0300)
committerJoerg Roedel <jroedel@suse.de>
Mon, 8 Feb 2021 08:11:06 +0000 (09:11 +0100)
This error path is supposed to return -EINVAL.  It used to return
directly but we added some clean up and accidentally removed the
error code.  Also I fixed a typo in the error message.

Fixes: c0b57581b73b ("iommu/mediatek: Add power-domain operation")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Yong Wu <yong.wu@mediatek.com>
Link: https://lore.kernel.org/r/YB0+GU5akSdu29Vu@mwanda
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/mtk_iommu.c

index 1f262621ef19e501eee94b7f2892db4fba846cd2..6ecc007f07cd52e80d7fa0cc6459291cad0d9f15 100644 (file)
@@ -886,7 +886,8 @@ static int mtk_iommu_probe(struct platform_device *pdev)
        link = device_link_add(data->smicomm_dev, dev,
                        DL_FLAG_STATELESS | DL_FLAG_PM_RUNTIME);
        if (!link) {
-               dev_err(dev, "Unable link %s.\n", dev_name(data->smicomm_dev));
+               dev_err(dev, "Unable to link %s.\n", dev_name(data->smicomm_dev));
+               ret = -EINVAL;
                goto out_runtime_disable;
        }