projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
0d6289c
)
tty: n_gsm: fix malformed counter for out of frame data
author
Daniel Starke
<daniel.starke@siemens.com>
Thu, 14 Apr 2022 09:42:12 +0000
(
02:42
-0700)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Mon, 9 May 2022 07:14:43 +0000
(09:14 +0200)
commit
a24b4b2f660b7ddf3f484b37600bba382cb28a9d
upstream.
The gsm_mux field 'malformed' represents the number of malformed frames
received. However, gsm1_receive() also increases this counter for any out
of frame byte.
Fix this by ignoring out of frame data for the malformed counter.
Fixes: e1eaea46bb40 ("tty: n_gsm line discipline")
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
Link:
https://lore.kernel.org/r/20220414094225.4527-7-daniel.starke@siemens.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/n_gsm.c
patch
|
blob
|
history
diff --git
a/drivers/tty/n_gsm.c
b/drivers/tty/n_gsm.c
index a2546c7acbae7d0496c7f187096ee716adc1a37f..43b403342729f45becb0a45ea488b1890c3823e5 100644
(file)
--- a/
drivers/tty/n_gsm.c
+++ b/
drivers/tty/n_gsm.c
@@
-1976,7
+1976,8
@@
static void gsm1_receive(struct gsm_mux *gsm, unsigned char c)
}
/* Any partial frame was a runt so go back to start */
if (gsm->state != GSM_START) {
- gsm->malformed++;
+ if (gsm->state != GSM_SEARCH)
+ gsm->malformed++;
gsm->state = GSM_START;
}
/* A SOF in GSM_START means we are still reading idling or