rtlwifi: Remove redundant assignments to ul_enc_algo
authorYang Li <yang.lee@linux.alibaba.com>
Tue, 18 May 2021 01:59:59 +0000 (09:59 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 15 Jun 2021 13:39:55 +0000 (16:39 +0300)
Variable ul_enc_algo is being initialized with a value that is never
read, it is being set again in the following switch statements in
all of the case and default paths. Hence the unitialization is
redundant and can be removed.

Clean up clang warning:

drivers/net/wireless/realtek/rtlwifi/cam.c:170:6: warning: Value stored
to 'ul_enc_algo' during its initialization is never read
[clang-analyzer-deadcode.DeadStores]

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1621303199-1542-1-git-send-email-yang.lee@linux.alibaba.com
drivers/net/wireless/realtek/rtlwifi/cam.c

index 7aa28da39409b2ac8ba56e68c3b00cd0f78a1eb2..7a0355dc6babd25d354651e39419dc310037039d 100644 (file)
@@ -167,7 +167,7 @@ void rtl_cam_mark_invalid(struct ieee80211_hw *hw, u8 uc_index)
 
        u32 ul_command;
        u32 ul_content;
-       u32 ul_enc_algo = rtlpriv->cfg->maps[SEC_CAM_AES];
+       u32 ul_enc_algo;
 
        switch (rtlpriv->sec.pairwise_enc_algorithm) {
        case WEP40_ENCRYPTION: