hwrng: mxc-rnga - Drop usage of platform_driver_probe()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Sun, 24 Mar 2024 16:12:26 +0000 (17:12 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Tue, 2 Apr 2024 02:49:39 +0000 (10:49 +0800)
There are considerations to drop platform_driver_probe() as a concept
that isn't relevant any more today. It comes with an added complexity
that makes many users hold it wrong. (E.g. this driver should have mark
the driver struct with __refdata.)

Convert the driver to the more usual module_platform_driver().

This fixes a W=1 build warning:

WARNING: modpost: drivers/char/hw_random/mxc-rnga: section mismatch in reference: mxc_rnga_driver+0x10 (section: .data) -> mxc_rnga_remove (section: .exit.text)

with CONFIG_HW_RANDOM_MXC_RNGA=m.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/mxc-rnga.c

index 07ec000e4cd711236aac836f471e975e95718644..94ee18a1120a81647b989213167163d782295b21 100644 (file)
@@ -131,7 +131,7 @@ static void mxc_rnga_cleanup(struct hwrng *rng)
        __raw_writel(ctrl & ~RNGA_CONTROL_GO, mxc_rng->mem + RNGA_CONTROL);
 }
 
-static int __init mxc_rnga_probe(struct platform_device *pdev)
+static int mxc_rnga_probe(struct platform_device *pdev)
 {
        int err;
        struct mxc_rng *mxc_rng;
@@ -176,7 +176,7 @@ err_ioremap:
        return err;
 }
 
-static void __exit mxc_rnga_remove(struct platform_device *pdev)
+static void mxc_rnga_remove(struct platform_device *pdev)
 {
        struct mxc_rng *mxc_rng = platform_get_drvdata(pdev);
 
@@ -197,10 +197,11 @@ static struct platform_driver mxc_rnga_driver = {
                .name = "mxc_rnga",
                .of_match_table = mxc_rnga_of_match,
        },
-       .remove_new = __exit_p(mxc_rnga_remove),
+       .probe = mxc_rnga_probe,
+       .remove_new = mxc_rnga_remove,
 };
 
-module_platform_driver_probe(mxc_rnga_driver, mxc_rnga_probe);
+module_platform_driver(mxc_rnga_driver);
 
 MODULE_AUTHOR("Freescale Semiconductor, Inc.");
 MODULE_DESCRIPTION("H/W RNGA driver for i.MX");