drm/panthor: clean up some types in panthor_sched_suspend()
authorDan Carpenter <dan.carpenter@linaro.org>
Mon, 8 Apr 2024 07:36:35 +0000 (10:36 +0300)
committerBoris Brezillon <boris.brezillon@collabora.com>
Mon, 22 Apr 2024 07:39:40 +0000 (09:39 +0200)
These variables should be u32 instead of u64 because they're only
storing u32 values.  Also static checkers complain when we do:

suspended_slots &= ~upd_ctx.timedout_mask;

In this code "suspended_slots" is a u64 and "upd_ctx.timedout_mask".  The
mask clears out the top 32 bits which would likely be a bug if anything
were stored there.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Steven Price <steven.price@arm.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/85356b15-4840-4e64-8c75-922cdd6a5fef@moroto.mountain
drivers/gpu/drm/panthor/panthor_sched.c

index d4bc652b34d5dfeb79debdfda542320ac1d401b1..b3a51a6de5235e7a52522ddbea47031618b1b18f 100644 (file)
@@ -2546,7 +2546,7 @@ void panthor_sched_suspend(struct panthor_device *ptdev)
 {
        struct panthor_scheduler *sched = ptdev->scheduler;
        struct panthor_csg_slots_upd_ctx upd_ctx;
-       u64 suspended_slots, faulty_slots;
+       u32 suspended_slots, faulty_slots;
        struct panthor_group *group;
        u32 i;