crypto: drbg - update FIPS CTR self-checks to aes256
authorDimitri John Ledkov <dimitri.ledkov@canonical.com>
Mon, 30 Oct 2023 12:05:14 +0000 (14:05 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 17 Nov 2023 11:16:29 +0000 (19:16 +0800)
When originally drbg was introduced FIPS self-checks for all types but
CTR were using the most preferred parameters for each type of
DRBG. Update CTR self-check to use aes256.

This patch updates code from 541af946fe ("crypto: drbg - SP800-90A
Deterministic Random Bit Generator"), but is not interesting to
cherry-pick for stable updates, because it doesn't affect regular
builds, nor has any tangible effect on FIPS certifcation.

Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
Reviewed-by: Stephan Mueller <smueller@chronox.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/drbg.c

index e3baaa5777f9beda7e55551e2499d25a410a2a92..52731bc57e705ff5a8317a8e9f299ec05e8f3a0b 100644 (file)
@@ -1478,8 +1478,8 @@ static int drbg_generate(struct drbg_state *drbg,
                        err = alg_test("drbg_pr_hmac_sha256",
                                       "drbg_pr_hmac_sha256", 0, 0);
                else if (drbg->core->flags & DRBG_CTR)
-                       err = alg_test("drbg_pr_ctr_aes128",
-                                      "drbg_pr_ctr_aes128", 0, 0);
+                       err = alg_test("drbg_pr_ctr_aes256",
+                                      "drbg_pr_ctr_aes256", 0, 0);
                else
                        err = alg_test("drbg_pr_sha256",
                                       "drbg_pr_sha256", 0, 0);
@@ -2017,7 +2017,7 @@ static inline int __init drbg_healthcheck_sanity(void)
                return 0;
 
 #ifdef CONFIG_CRYPTO_DRBG_CTR
-       drbg_convert_tfm_core("drbg_nopr_ctr_aes128", &coreref, &pr);
+       drbg_convert_tfm_core("drbg_nopr_ctr_aes256", &coreref, &pr);
 #endif
 #ifdef CONFIG_CRYPTO_DRBG_HASH
        drbg_convert_tfm_core("drbg_nopr_sha256", &coreref, &pr);