hw/arm/omap1:Remove redundant statement in omap_clkdsp_read()
authorChen Qun <kuhn.chenqun@huawei.com>
Thu, 27 Aug 2020 11:03:03 +0000 (19:03 +0800)
committerLaurent Vivier <laurent@vivier.eu>
Tue, 1 Sep 2020 09:53:44 +0000 (11:53 +0200)
Clang static code analyzer show warning:
hw/arm/omap1.c:1760:15: warning: Value stored to 'cpu' during its
initialization is never read
    CPUState *cpu = CPU(s->cpu);
              ^~~   ~~~~~~~~~~~

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Message-Id: <20200827110311.164316-3-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
hw/arm/omap1.c

index 6ba0df6b6d092983d171d777daaef46eca7ca7f6..02c0f66431b98747813c9f5591b893d13f44fc00 100644 (file)
@@ -1774,7 +1774,6 @@ static uint64_t omap_clkdsp_read(void *opaque, hwaddr addr,
         return s->clkm.dsp_rstct2;
 
     case 0x18: /* DSP_SYSST */
-        cpu = CPU(s->cpu);
         return (s->clkm.clocking_scheme << 11) | s->clkm.cold_start |
                 (cpu->halted << 6);      /* Quite useless... */
     }