Merge tag 'mem-2024-12-21' of https://github.com/davidhildenbrand/qemu into staging
authorStefan Hajnoczi <stefanha@redhat.com>
Sun, 22 Dec 2024 15:45:35 +0000 (10:45 -0500)
committerStefan Hajnoczi <stefanha@redhat.com>
Sun, 22 Dec 2024 19:33:27 +0000 (14:33 -0500)
Hi,

"Host Memory Backends" and "Memory devices" queue ("mem"):
- Fixup handling of virtio-mem unplug during system resets, as
  preparation for s390x support (especially kdump in the Linux guest)
- virtio-mem support for s390x

 # -----BEGIN PGP SIGNATURE-----
 #
 # iQJFBAABCAAvFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmdnFD4RHGRhdmlkQHJl
 # ZGhhdC5jb20ACgkQTd4Q9wD/g1rWBBAAp7WkYaNAjRy1PgpjNZ3z1gUJc/vk+skJ
 # xVgGodA8txrJOFpNrbTyfhrdLs2TV4oWDvB/zrZRRtuxvur3O1EhFd9k6EqXuydr
 # 0FunvLvVJwRHfEZycjN4aacQMRH3CJw07OaTzexeSl5UR/6w5PRofwUK4HX7W/Ka
 # arqomGa3OJrs1+WgkV0Qcn4vh9HLRVv3iNC2Xo4W1wOCr1Du9zSPn9oC7zOQ0EO4
 # ZC//7QsdkNRjUX/yMXMkhlSXx3b/RmRg2DBrxo7BZXg27VwGu4uHxL4LRBZiB2A7
 # V9MqFOcVKzPMkXKTRjrgZ0vXQx1MPJ6WprEihMzMpYU6DrpA7KN/l8Ca8H24B2ln
 # h7+bmkDsHVVcWovE9ii/9cMRfws6uWXXg3KoA8RQ8IbX1tU02lblw2uHhXEzcoge
 # npqp/Z5LAiKVMetEnNnLH5thjut5PAEjuqD00cmZAMy4DNngLX2bGSdzMeVBkDMa
 # 78ehLGRplm3t7ibUfaZaMKe6UD9tFrcD6XKsvUTXXHNbYO8ynbx58WOxSZmY98zU
 # n3JNQRqtXYjBVlH3Dqm47vOTZHgOzFv3raa8BmSLpcBDeTXCTcUIl20s77dGw/vT
 # r5YNCMN7O4YPFKUoRK9604QTgw6qlYaRTQlJD09usprGqVylb6gQtfZZuZkYDMp8
 # sEI77QHsePA=
 # =HDxr
 # -----END PGP SIGNATURE-----
 # gpg: Signature made Sat 21 Dec 2024 14:17:18 EST
 # gpg:                using RSA key 1BD9CAAD735C4C3A460DFCCA4DDE10F700FF835A
 # gpg:                issuer "david@redhat.com"
 # gpg: Good signature from "David Hildenbrand <david@redhat.com>" [unknown]
 # gpg:                 aka "David Hildenbrand <davidhildenbrand@gmail.com>" [full]
 # gpg:                 aka "David Hildenbrand <hildenbr@in.tum.de>" [unknown]
 # gpg: WARNING: The key's User ID is not certified with a trusted signature!
 # gpg:          There is no indication that the signature belongs to the owner.
 # Primary key fingerprint: 1BD9 CAAD 735C 4C3A 460D  FCCA 4DDE 10F7 00FF 835A

* tag 'mem-2024-12-21' of https://github.com/davidhildenbrand/qemu:
  s390x: virtio-mem support
  s390x/virtio-ccw: add support for virtio based memory devices
  s390x: remember the maximum page size
  s390x/pv: prepare for memory devices
  s390x/s390-virtio-ccw: prepare for memory devices
  s390x/s390-skeys: prepare for memory devices
  s390x/s390-stattrib-kvm: prepare for memory devices and sparse memory layouts
  s390x/s390-hypercall: introduce DIAG500 STORAGE_LIMIT
  s390x: introduce s390_get_memory_limit()
  s390x/s390-virtio-ccw: move setting the maximum guest size from sclp to machine code
  s390x: rename s390-virtio-hcall* to s390-hypercall*
  s390x/s390-virtio-hcall: prepare for more diag500 hypercalls
  s390x/s390-virtio-hcall: remove hypercall registration mechanism
  s390x/s390-virtio-ccw: don't crash on weird RAM sizes
  virtio-mem: unplug memory only during system resets, not device resets

Conflicts:
- hw/s390x/s390-stattrib-kvm.c
  sysemu/ -> system/ header rename conflict.
- hw/s390x/virtio-ccw-mem.c
  Make Property array const and removed DEFINE_PROP_END_OF_LIST() to
  conform to the latest conventions.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
1  2 
MAINTAINERS
hw/s390x/s390-skeys.c
hw/s390x/s390-stattrib-kvm.c
hw/s390x/s390-virtio-ccw.c
hw/s390x/virtio-ccw-mem.c
hw/virtio/virtio-mem.c
include/hw/virtio/virtio-mem.h
target/s390x/cpu-system.c
target/s390x/kvm/kvm.c
target/s390x/kvm/pv.c
target/s390x/tcg/misc_helper.c

diff --cc MAINTAINERS
Simple merge
Simple merge
index 508fd558e826fbfe0a30bf54df53414a839da72a,33ec91422a6d66ccce805f14b91bb5a219af45d2..2a8e31718bf51865db365497868e0fd7b135f8e3
@@@ -14,7 -14,8 +14,8 @@@
  #include "migration/qemu-file.h"
  #include "hw/s390x/storage-attributes.h"
  #include "qemu/error-report.h"
 -#include "sysemu/kvm.h"
 -#include "sysemu/memory_mapping.h"
 +#include "system/kvm.h"
++#include "system/memory_mapping.h"
  #include "exec/ram_addr.h"
  #include "kvm/kvm_s390x.h"
  #include "qapi/error.h"
index b45d8963b36c02d01fb7446a854a16ac8e6aa241,097ec78826d89f61fc1fef1575e6be8489771acb..2be8da291319be2ab98b57ee9eeadc710c73c8b1
  #include "qemu/osdep.h"
  #include "qapi/error.h"
  #include "exec/ram_addr.h"
 -#include "exec/confidential-guest-support.h"
 +#include "system/confidential-guest-support.h"
  #include "hw/boards.h"
- #include "hw/s390x/s390-virtio-hcall.h"
  #include "hw/s390x/sclp.h"
  #include "hw/s390x/s390_flic.h"
- #include "hw/s390x/ioinst.h"
- #include "hw/s390x/css.h"
  #include "virtio-ccw.h"
  #include "qemu/config-file.h"
  #include "qemu/ctype.h"
index 0000000000000000000000000000000000000000,bee0d560cb6b53d76a200a03b0be0b6fc334fa3b..90fd89f0156d15232ce3fc62fc30e9b68d7cf1f4
mode 000000,100644..100644
--- /dev/null
@@@ -1,0 -1,226 +1,225 @@@
 -static Property virtio_ccw_mem_properties[] = {
+ /*
+  * virtio-mem CCW implementation
+  *
+  * Copyright (C) 2024 Red Hat, Inc.
+  *
+  * Authors:
+  *  David Hildenbrand <david@redhat.com>
+  *
+  * This work is licensed under the terms of the GNU GPL, version 2.
+  * See the COPYING file in the top-level directory.
+  */
+ #include "qemu/osdep.h"
+ #include "hw/qdev-properties.h"
+ #include "qapi/error.h"
+ #include "qemu/module.h"
+ #include "virtio-ccw-mem.h"
+ #include "hw/mem/memory-device.h"
+ #include "qapi/qapi-events-machine.h"
+ #include "qapi/qapi-events-misc.h"
+ static void virtio_ccw_mem_realize(VirtioCcwDevice *ccw_dev, Error **errp)
+ {
+     VirtIOMEMCcw *dev = VIRTIO_MEM_CCW(ccw_dev);
+     DeviceState *vdev = DEVICE(&dev->vdev);
+     qdev_realize(vdev, BUS(&ccw_dev->bus), errp);
+ }
+ static void virtio_ccw_mem_set_addr(MemoryDeviceState *md, uint64_t addr,
+                                     Error **errp)
+ {
+     object_property_set_uint(OBJECT(md), VIRTIO_MEM_ADDR_PROP, addr, errp);
+ }
+ static uint64_t virtio_ccw_mem_get_addr(const MemoryDeviceState *md)
+ {
+     return object_property_get_uint(OBJECT(md), VIRTIO_MEM_ADDR_PROP,
+                                     &error_abort);
+ }
+ static MemoryRegion *virtio_ccw_mem_get_memory_region(MemoryDeviceState *md,
+                                                       Error **errp)
+ {
+     VirtIOMEMCcw *dev = VIRTIO_MEM_CCW(md);
+     VirtIOMEM *vmem = &dev->vdev;
+     VirtIOMEMClass *vmc = VIRTIO_MEM_GET_CLASS(vmem);
+     return vmc->get_memory_region(vmem, errp);
+ }
+ static void virtio_ccw_mem_decide_memslots(MemoryDeviceState *md,
+                                            unsigned int limit)
+ {
+     VirtIOMEMCcw *dev = VIRTIO_MEM_CCW(md);
+     VirtIOMEM *vmem = VIRTIO_MEM(&dev->vdev);
+     VirtIOMEMClass *vmc = VIRTIO_MEM_GET_CLASS(vmem);
+     vmc->decide_memslots(vmem, limit);
+ }
+ static unsigned int virtio_ccw_mem_get_memslots(MemoryDeviceState *md)
+ {
+     VirtIOMEMCcw *dev = VIRTIO_MEM_CCW(md);
+     VirtIOMEM *vmem = VIRTIO_MEM(&dev->vdev);
+     VirtIOMEMClass *vmc = VIRTIO_MEM_GET_CLASS(vmem);
+     return vmc->get_memslots(vmem);
+ }
+ static uint64_t virtio_ccw_mem_get_plugged_size(const MemoryDeviceState *md,
+                                                 Error **errp)
+ {
+     return object_property_get_uint(OBJECT(md), VIRTIO_MEM_SIZE_PROP,
+                                     errp);
+ }
+ static void virtio_ccw_mem_fill_device_info(const MemoryDeviceState *md,
+                                             MemoryDeviceInfo *info)
+ {
+     VirtioMEMDeviceInfo *vi = g_new0(VirtioMEMDeviceInfo, 1);
+     VirtIOMEMCcw *dev = VIRTIO_MEM_CCW(md);
+     VirtIOMEM *vmem = &dev->vdev;
+     VirtIOMEMClass *vpc = VIRTIO_MEM_GET_CLASS(vmem);
+     DeviceState *vdev = DEVICE(md);
+     if (vdev->id) {
+         vi->id = g_strdup(vdev->id);
+     }
+     /* let the real device handle everything else */
+     vpc->fill_device_info(vmem, vi);
+     info->u.virtio_mem.data = vi;
+     info->type = MEMORY_DEVICE_INFO_KIND_VIRTIO_MEM;
+ }
+ static uint64_t virtio_ccw_mem_get_min_alignment(const MemoryDeviceState *md)
+ {
+     return object_property_get_uint(OBJECT(md), VIRTIO_MEM_BLOCK_SIZE_PROP,
+                                     &error_abort);
+ }
+ static void virtio_ccw_mem_size_change_notify(Notifier *notifier, void *data)
+ {
+     VirtIOMEMCcw *dev = container_of(notifier, VirtIOMEMCcw,
+                                          size_change_notifier);
+     DeviceState *vdev = DEVICE(dev);
+     char *qom_path = object_get_canonical_path(OBJECT(dev));
+     const uint64_t * const size_p = data;
+     qapi_event_send_memory_device_size_change(vdev->id, *size_p, qom_path);
+     g_free(qom_path);
+ }
+ static void virtio_ccw_mem_unplug_request_check(VirtIOMDCcw *vmd, Error **errp)
+ {
+     VirtIOMEMCcw *dev = VIRTIO_MEM_CCW(vmd);
+     VirtIOMEM *vmem = &dev->vdev;
+     VirtIOMEMClass *vpc = VIRTIO_MEM_GET_CLASS(vmem);
+     vpc->unplug_request_check(vmem, errp);
+ }
+ static void virtio_ccw_mem_get_requested_size(Object *obj, Visitor *v,
+                                               const char *name, void *opaque,
+                                               Error **errp)
+ {
+     VirtIOMEMCcw *dev = VIRTIO_MEM_CCW(obj);
+     object_property_get(OBJECT(&dev->vdev), name, v, errp);
+ }
+ static void virtio_ccw_mem_set_requested_size(Object *obj, Visitor *v,
+                                               const char *name, void *opaque,
+                                               Error **errp)
+ {
+     VirtIOMEMCcw *dev = VIRTIO_MEM_CCW(obj);
+     DeviceState *vdev = DEVICE(obj);
+     /*
+      * If we passed virtio_ccw_mem_unplug_request_check(), making sure that
+      * the requested size is 0, don't allow modifying the requested size
+      * anymore, otherwise the VM might end up hotplugging memory before
+      * handling the unplug request.
+      */
+     if (vdev->pending_deleted_event) {
+         error_setg(errp, "'%s' cannot be changed if the device is in the"
+                    " process of unplug", name);
+         return;
+     }
+     object_property_set(OBJECT(&dev->vdev), name, v, errp);
+ }
 -    DEFINE_PROP_END_OF_LIST(),
++static const Property virtio_ccw_mem_properties[] = {
+     DEFINE_PROP_BIT("ioeventfd", VirtioCcwDevice, flags,
+                     VIRTIO_CCW_FLAG_USE_IOEVENTFD_BIT, true),
+     DEFINE_PROP_UINT32("max_revision", VirtioCcwDevice, max_rev,
+                        VIRTIO_CCW_MAX_REV),
+ };
+ static void virtio_ccw_mem_class_init(ObjectClass *klass, void *data)
+ {
+     DeviceClass *dc = DEVICE_CLASS(klass);
+     VirtIOCCWDeviceClass *k = VIRTIO_CCW_DEVICE_CLASS(klass);
+     MemoryDeviceClass *mdc = MEMORY_DEVICE_CLASS(klass);
+     VirtIOMDCcwClass *vmdc = VIRTIO_MD_CCW_CLASS(klass);
+     k->realize = virtio_ccw_mem_realize;
+     set_bit(DEVICE_CATEGORY_MISC, dc->categories);
+     device_class_set_props(dc, virtio_ccw_mem_properties);
+     mdc->get_addr = virtio_ccw_mem_get_addr;
+     mdc->set_addr = virtio_ccw_mem_set_addr;
+     mdc->get_plugged_size = virtio_ccw_mem_get_plugged_size;
+     mdc->get_memory_region = virtio_ccw_mem_get_memory_region;
+     mdc->decide_memslots = virtio_ccw_mem_decide_memslots;
+     mdc->get_memslots = virtio_ccw_mem_get_memslots;
+     mdc->fill_device_info = virtio_ccw_mem_fill_device_info;
+     mdc->get_min_alignment = virtio_ccw_mem_get_min_alignment;
+     vmdc->unplug_request_check = virtio_ccw_mem_unplug_request_check;
+ }
+ static void virtio_ccw_mem_instance_init(Object *obj)
+ {
+     VirtIOMEMCcw *dev = VIRTIO_MEM_CCW(obj);
+     VirtIOMEMClass *vmc;
+     VirtIOMEM *vmem;
+     virtio_instance_init_common(obj, &dev->vdev, sizeof(dev->vdev),
+                                 TYPE_VIRTIO_MEM);
+     dev->size_change_notifier.notify = virtio_ccw_mem_size_change_notify;
+     vmem = &dev->vdev;
+     vmc = VIRTIO_MEM_GET_CLASS(vmem);
+     /*
+      * We never remove the notifier again, as we expect both devices to
+      * disappear at the same time.
+      */
+     vmc->add_size_change_notifier(vmem, &dev->size_change_notifier);
+     object_property_add_alias(obj, VIRTIO_MEM_BLOCK_SIZE_PROP,
+                               OBJECT(&dev->vdev), VIRTIO_MEM_BLOCK_SIZE_PROP);
+     object_property_add_alias(obj, VIRTIO_MEM_SIZE_PROP, OBJECT(&dev->vdev),
+                               VIRTIO_MEM_SIZE_PROP);
+     object_property_add(obj, VIRTIO_MEM_REQUESTED_SIZE_PROP, "size",
+                         virtio_ccw_mem_get_requested_size,
+                         virtio_ccw_mem_set_requested_size, NULL, NULL);
+ }
+ static const TypeInfo virtio_ccw_mem = {
+     .name = TYPE_VIRTIO_MEM_CCW,
+     .parent = TYPE_VIRTIO_MD_CCW,
+     .instance_size = sizeof(VirtIOMEMCcw),
+     .instance_init = virtio_ccw_mem_instance_init,
+     .class_init = virtio_ccw_mem_class_init,
+ };
+ static void virtio_ccw_mem_register_types(void)
+ {
+     type_register_static(&virtio_ccw_mem);
+ }
+ type_init(virtio_ccw_mem_register_types)
Simple merge
Simple merge
index 2ba2598ae0f838136d054498ca6002ac9fa54130,0000000000000000000000000000000000000000..e9f8e7cc72f5f56c19235c0cd8ada0cd24edd5b9
mode 100644,000000..100644
--- /dev/null
@@@ -1,322 -1,0 +1,307 @@@
- int s390_set_memory_limit(uint64_t new_limit, uint64_t *hw_limit)
- {
-     if (kvm_enabled()) {
-         return kvm_s390_set_mem_limit(new_limit, hw_limit);
-     }
-     return 0;
- }
- void s390_set_max_pagesize(uint64_t pagesize, Error **errp)
- {
-     if (kvm_enabled()) {
-         kvm_s390_set_max_pagesize(pagesize, errp);
-     }
- }
 +/*
 + * QEMU S/390 CPU - System-only code
 + *
 + * Copyright (c) 2009 Ulrich Hecht
 + * Copyright (c) 2011 Alexander Graf
 + * Copyright (c) 2012 SUSE LINUX Products GmbH
 + * Copyright (c) 2012 IBM Corp.
 + *
 + * This program is free software; you can redistribute it and/or modify
 + * it under the terms of the GNU General Public License as published by
 + * the Free Software Foundation; either version 2 of the License, or
 + * (at your option) any later version.
 + *
 + * This program is distributed in the hope that it will be useful,
 + * but WITHOUT ANY WARRANTY; without even the implied warranty of
 + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 + * General Public License for more details.
 + *
 + * You should have received a copy of the GNU General Public License
 + * along with this program; if not, see <http://www.gnu.org/licenses/>.
 + */
 +
 +#include "qemu/osdep.h"
 +#include "qemu/error-report.h"
 +#include "qapi/error.h"
 +#include "cpu.h"
 +#include "s390x-internal.h"
 +#include "kvm/kvm_s390x.h"
 +#include "system/kvm.h"
 +#include "system/reset.h"
 +#include "qemu/timer.h"
 +#include "trace.h"
 +#include "qapi/qapi-visit-run-state.h"
 +#include "system/hw_accel.h"
 +
 +#include "target/s390x/kvm/pv.h"
 +#include "hw/boards.h"
 +#include "system/system.h"
 +#include "system/tcg.h"
 +#include "hw/core/sysemu-cpu-ops.h"
 +
 +/* S390CPUClass::load_normal() */
 +static void s390_cpu_load_normal(CPUState *s)
 +{
 +    S390CPU *cpu = S390_CPU(s);
 +    uint64_t spsw;
 +
 +    if (!s390_is_pv()) {
 +        spsw = ldq_phys(s->as, 0);
 +        cpu->env.psw.mask = spsw & PSW_MASK_SHORT_CTRL;
 +        /*
 +         * Invert short psw indication, so SIE will report a specification
 +         * exception if it was not set.
 +         */
 +        cpu->env.psw.mask ^= PSW_MASK_SHORTPSW;
 +        cpu->env.psw.addr = spsw & PSW_MASK_SHORT_ADDR;
 +    } else {
 +        /*
 +         * Firmware requires us to set the load state before we set
 +         * the cpu to operating on protected guests.
 +         */
 +        s390_cpu_set_state(S390_CPU_STATE_LOAD, cpu);
 +    }
 +    s390_cpu_set_state(S390_CPU_STATE_OPERATING, cpu);
 +}
 +
 +void s390_cpu_machine_reset_cb(void *opaque)
 +{
 +    S390CPU *cpu = opaque;
 +
 +    run_on_cpu(CPU(cpu), s390_do_cpu_full_reset, RUN_ON_CPU_NULL);
 +}
 +
 +static GuestPanicInformation *s390_cpu_get_crash_info(CPUState *cs)
 +{
 +    GuestPanicInformation *panic_info;
 +    S390CPU *cpu = S390_CPU(cs);
 +
 +    cpu_synchronize_state(cs);
 +    panic_info = g_new0(GuestPanicInformation, 1);
 +
 +    panic_info->type = GUEST_PANIC_INFORMATION_TYPE_S390;
 +    panic_info->u.s390.core = cpu->env.core_id;
 +    panic_info->u.s390.psw_mask = cpu->env.psw.mask;
 +    panic_info->u.s390.psw_addr = cpu->env.psw.addr;
 +    panic_info->u.s390.reason = cpu->env.crash_reason;
 +
 +    return panic_info;
 +}
 +
 +static void s390_cpu_get_crash_info_qom(Object *obj, Visitor *v,
 +                                        const char *name, void *opaque,
 +                                        Error **errp)
 +{
 +    CPUState *cs = CPU(obj);
 +    GuestPanicInformation *panic_info;
 +
 +    if (!cs->crash_occurred) {
 +        error_setg(errp, "No crash occurred");
 +        return;
 +    }
 +
 +    panic_info = s390_cpu_get_crash_info(cs);
 +
 +    visit_type_GuestPanicInformation(v, "crash-information", &panic_info,
 +                                     errp);
 +    qapi_free_GuestPanicInformation(panic_info);
 +}
 +
 +void s390_cpu_system_init(Object *obj)
 +{
 +    CPUState *cs = CPU(obj);
 +    S390CPU *cpu = S390_CPU(obj);
 +
 +    cs->start_powered_off = true;
 +    object_property_add(obj, "crash-information", "GuestPanicInformation",
 +                        s390_cpu_get_crash_info_qom, NULL, NULL, NULL);
 +    cpu->env.tod_timer =
 +        timer_new_ns(QEMU_CLOCK_VIRTUAL, s390x_tod_timer, cpu);
 +    cpu->env.cpu_timer =
 +        timer_new_ns(QEMU_CLOCK_VIRTUAL, s390x_cpu_timer, cpu);
 +    s390_cpu_set_state(S390_CPU_STATE_STOPPED, cpu);
 +}
 +
 +bool s390_cpu_system_realize(DeviceState *dev, Error **errp)
 +{
 +    S390CPU *cpu = S390_CPU(dev);
 +    MachineState *ms = MACHINE(qdev_get_machine());
 +    unsigned int max_cpus = ms->smp.max_cpus;
 +
 +    if (cpu->env.core_id >= max_cpus) {
 +        error_setg(errp, "Unable to add CPU with core-id: %" PRIu32
 +                   ", maximum core-id: %d", cpu->env.core_id,
 +                   max_cpus - 1);
 +        return false;
 +    }
 +
 +    if (cpu_exists(cpu->env.core_id)) {
 +        error_setg(errp, "Unable to add CPU with core-id: %" PRIu32
 +                   ", it already exists", cpu->env.core_id);
 +        return false;
 +    }
 +
 +    /* sync cs->cpu_index and env->core_id. The latter is needed for TCG. */
 +    CPU(cpu)->cpu_index = cpu->env.core_id;
 +    return true;
 +}
 +
 +void s390_cpu_finalize(Object *obj)
 +{
 +    S390CPU *cpu = S390_CPU(obj);
 +
 +    timer_free(cpu->env.tod_timer);
 +    timer_free(cpu->env.cpu_timer);
 +
 +    qemu_unregister_reset(s390_cpu_machine_reset_cb, cpu);
 +    g_free(cpu->irqstate);
 +}
 +
 +static const struct SysemuCPUOps s390_sysemu_ops = {
 +    .get_phys_page_debug = s390_cpu_get_phys_page_debug,
 +    .get_crash_info = s390_cpu_get_crash_info,
 +    .write_elf64_note = s390_cpu_write_elf64_note,
 +    .legacy_vmsd = &vmstate_s390_cpu,
 +};
 +
 +void s390_cpu_system_class_init(CPUClass *cc)
 +{
 +    S390CPUClass *scc = S390_CPU_CLASS(cc);
 +
 +    scc->load_normal = s390_cpu_load_normal;
 +    cc->sysemu_ops = &s390_sysemu_ops;
 +}
 +
 +static bool disabled_wait(CPUState *cpu)
 +{
 +    return cpu->halted && !(S390_CPU(cpu)->env.psw.mask &
 +                            (PSW_MASK_IO | PSW_MASK_EXT | PSW_MASK_MCHECK));
 +}
 +
 +static unsigned s390_count_running_cpus(void)
 +{
 +    CPUState *cpu;
 +    int nr_running = 0;
 +
 +    CPU_FOREACH(cpu) {
 +        uint8_t state = S390_CPU(cpu)->env.cpu_state;
 +        if (state == S390_CPU_STATE_OPERATING ||
 +            state == S390_CPU_STATE_LOAD) {
 +            if (!disabled_wait(cpu)) {
 +                nr_running++;
 +            }
 +        }
 +    }
 +
 +    return nr_running;
 +}
 +
 +unsigned int s390_cpu_halt(S390CPU *cpu)
 +{
 +    CPUState *cs = CPU(cpu);
 +    trace_cpu_halt(cs->cpu_index);
 +
 +    if (!cs->halted) {
 +        cs->halted = 1;
 +        cs->exception_index = EXCP_HLT;
 +    }
 +
 +    return s390_count_running_cpus();
 +}
 +
 +void s390_cpu_unhalt(S390CPU *cpu)
 +{
 +    CPUState *cs = CPU(cpu);
 +    trace_cpu_unhalt(cs->cpu_index);
 +
 +    if (cs->halted) {
 +        cs->halted = 0;
 +        cs->exception_index = -1;
 +    }
 +}
 +
 +unsigned int s390_cpu_set_state(uint8_t cpu_state, S390CPU *cpu)
 + {
 +    trace_cpu_set_state(CPU(cpu)->cpu_index, cpu_state);
 +
 +    switch (cpu_state) {
 +    case S390_CPU_STATE_STOPPED:
 +    case S390_CPU_STATE_CHECK_STOP:
 +        /* halt the cpu for common infrastructure */
 +        s390_cpu_halt(cpu);
 +        break;
 +    case S390_CPU_STATE_OPERATING:
 +    case S390_CPU_STATE_LOAD:
 +        /*
 +         * Starting a CPU with a PSW WAIT bit set:
 +         * KVM: handles this internally and triggers another WAIT exit.
 +         * TCG: will actually try to continue to run. Don't unhalt, will
 +         *      be done when the CPU actually has work (an interrupt).
 +         */
 +        if (!tcg_enabled() || !(cpu->env.psw.mask & PSW_MASK_WAIT)) {
 +            s390_cpu_unhalt(cpu);
 +        }
 +        break;
 +    default:
 +        error_report("Requested CPU state is not a valid S390 CPU state: %u",
 +                     cpu_state);
 +        exit(1);
 +    }
 +    if (kvm_enabled() && cpu->env.cpu_state != cpu_state) {
 +        kvm_s390_set_cpu_state(cpu, cpu_state);
 +    }
 +    cpu->env.cpu_state = cpu_state;
 +
 +    return s390_count_running_cpus();
 +}
 +
 +void s390_cmma_reset(void)
 +{
 +    if (kvm_enabled()) {
 +        kvm_s390_cmma_reset();
 +    }
 +}
 +
 +int s390_assign_subch_ioeventfd(EventNotifier *notifier, uint32_t sch_id,
 +                                int vq, bool assign)
 +{
 +    if (kvm_enabled()) {
 +        return kvm_s390_assign_subch_ioeventfd(notifier, sch_id, vq, assign);
 +    } else {
 +        return 0;
 +    }
 +}
 +
 +void s390_crypto_reset(void)
 +{
 +    if (kvm_enabled()) {
 +        kvm_s390_crypto_reset();
 +    }
 +}
 +
 +void s390_enable_css_support(S390CPU *cpu)
 +{
 +    if (kvm_enabled()) {
 +        kvm_s390_enable_css_support(cpu);
 +    }
 +}
 +
 +void s390_do_cpu_set_diag318(CPUState *cs, run_on_cpu_data arg)
 +{
 +    if (kvm_enabled()) {
 +        kvm_s390_set_diag318(cs, arg.host_ulong);
 +    }
 +}
 +
 +void s390_cpu_topology_set_changed(bool changed)
 +{
 +    int ret;
 +
 +    if (kvm_enabled()) {
 +        ret = kvm_s390_topology_set_mtcr(changed);
 +        if (ret) {
 +            error_report("Failed to set Modified Topology Change Report: %s",
 +                         strerror(-ret));
 +        }
 +    }
 +}
Simple merge
Simple merge
index ea25197d730e5aa9638b35806ea311cfef4af2c1,b726a95352a3239669a35955246cae8109f5af15..0245451472e7fa59974cfe42c275a7f81a4424cf
  #include "s390-tod.h"
  
  #if !defined(CONFIG_USER_ONLY)
 -#include "sysemu/cpus.h"
 -#include "sysemu/sysemu.h"
 +#include "system/cpus.h"
 +#include "system/system.h"
  #include "hw/s390x/ebcdic.h"
- #include "hw/s390x/s390-virtio-hcall.h"
+ #include "hw/s390x/s390-hypercall.h"
  #include "hw/s390x/sclp.h"
  #include "hw/s390x/s390_flic.h"
  #include "hw/s390x/ioinst.h"