f2fs: fix to disable compression on directory
authorChao Yu <yuchao0@huawei.com>
Fri, 27 Mar 2020 10:29:51 +0000 (18:29 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Fri, 3 Apr 2020 17:21:32 +0000 (10:21 -0700)
It needs to call f2fs_disable_compressed_file() to disable
compression on directory.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/f2fs.h
fs/f2fs/file.c

index c44afc5986386fb414aecaf4a16a2da3c5ddb7d9..c84442eefc56d25211c9e5999e738830f3085266 100644 (file)
@@ -3849,10 +3849,12 @@ static inline u64 f2fs_disable_compressed_file(struct inode *inode)
 
        if (!f2fs_compressed_file(inode))
                return 0;
-       if (get_dirty_pages(inode))
-               return 1;
-       if (fi->i_compr_blocks)
-               return fi->i_compr_blocks;
+       if (S_ISREG(inode->i_mode)) {
+               if (get_dirty_pages(inode))
+                       return 1;
+               if (fi->i_compr_blocks)
+                       return fi->i_compr_blocks;
+       }
 
        fi->i_flags &= ~F2FS_COMPR_FL;
        stat_dec_compr_inode(inode);
index 1476a3bc6317c33371d562c03d40a13ff9002e48..6cb3c6cae7cd03ece66ba7a84214c28d140ed577 100644 (file)
@@ -1815,7 +1815,7 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
        }
 
        if ((iflags ^ masked_flags) & F2FS_COMPR_FL) {
-               if (S_ISREG(inode->i_mode) && (masked_flags & F2FS_COMPR_FL)) {
+               if (masked_flags & F2FS_COMPR_FL) {
                        if (f2fs_disable_compressed_file(inode))
                                return -EINVAL;
                }