rtc: sun6i: Fix return value check in sun6i_rtc_clk_init()
authorWei Yongjun <weiyongjun1@huawei.com>
Thu, 9 Feb 2017 00:16:13 +0000 (00:16 +0000)
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>
Sat, 11 Feb 2017 23:34:31 +0000 (00:34 +0100)
In case of error, the function of_io_request_and_map() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: 847b8bf62eb4 ("rtc: sun6i: Expose the 32kHz oscillator")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
drivers/rtc/rtc-sun6i.c

index 08510ca58996037cd3f5dce302a8a1b77a194572..39cbc1238b92bbb5766d558b53435ae9ffee0ddd 100644 (file)
@@ -202,7 +202,7 @@ static void __init sun6i_rtc_clk_init(struct device_node *node)
        spin_lock_init(&rtc->lock);
 
        rtc->base = of_io_request_and_map(node, 0, of_node_full_name(node));
-       if (!rtc->base) {
+       if (IS_ERR(rtc->base)) {
                pr_crit("Can't map RTC registers");
                return;
        }