teaming: deliver link-local packets with the link they arrive on
authorjeffreyji <jeffreyji@google.com>
Thu, 17 Feb 2022 21:23:12 +0000 (21:23 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 18 Feb 2022 11:40:52 +0000 (11:40 +0000)
skb is ignored if team port is disabled. We want the skb to be delivered
if it's an link layer packet.

Issue is already fixed for bonding in
commit b89f04c61efe ("bonding: deliver link-local packets with skb->dev set to link that packets arrived on")

changelog:

v2: change LLDP -> link layer in comments/commit descrip, comment format

Signed-off-by: jeffreyji <jeffreyji@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/team/team.c

index 8b2adc56b92a8ed8b08e9b8220ccaf43f841ce40..b07dde6f0abf273195ff0f60217bd7158535b153 100644 (file)
@@ -734,6 +734,11 @@ static rx_handler_result_t team_handle_frame(struct sk_buff **pskb)
        port = team_port_get_rcu(skb->dev);
        team = port->team;
        if (!team_port_enabled(port)) {
+               if (is_link_local_ether_addr(eth_hdr(skb)->h_dest))
+                       /* link-local packets are mostly useful when stack receives them
+                        * with the link they arrive on.
+                        */
+                       return RX_HANDLER_PASS;
                /* allow exact match delivery for disabled ports */
                res = RX_HANDLER_EXACT;
        } else {