i2c: ali1535: remove printout on handled timeouts
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Tue, 23 Apr 2024 12:13:19 +0000 (14:13 +0200)
committerAndi Shyti <andi.shyti@kernel.org>
Sun, 5 May 2024 22:56:48 +0000 (00:56 +0200)
I2C and SMBus timeouts are not something the user needs to be informed
about on controller level. The client driver may know if that really is
a problem and give more detailed information to the user. The controller
should just pass this information upwards. Remove the printout.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-ali1535.c

index 461eb23f9d476786bebadbbb79c888f6aa0a057f..9d7b4efe26ad01b8edfcbc3bd4e8aa30d0670a38 100644 (file)
@@ -285,10 +285,8 @@ static int ali1535_transaction(struct i2c_adapter *adap)
                 && (timeout++ < MAX_TIMEOUT));
 
        /* If the SMBus is still busy, we give up */
-       if (timeout > MAX_TIMEOUT) {
+       if (timeout > MAX_TIMEOUT)
                result = -ETIMEDOUT;
-               dev_err(&adap->dev, "SMBus Timeout!\n");
-       }
 
        if (temp & ALI1535_STS_FAIL) {
                result = -EIO;
@@ -313,10 +311,8 @@ static int ali1535_transaction(struct i2c_adapter *adap)
        }
 
        /* check to see if the "command complete" indication is set */
-       if (!(temp & ALI1535_STS_DONE)) {
+       if (!(temp & ALI1535_STS_DONE))
                result = -ETIMEDOUT;
-               dev_err(&adap->dev, "Error: command never completed\n");
-       }
 
        dev_dbg(&adap->dev, "Transaction (post): STS=%02x, TYP=%02x, "
                "CMD=%02x, ADD=%02x, DAT0=%02x, DAT1=%02x\n",