ALSA: ump: Drop redundant check of note-on with zero velocity

The check of a note-on event with zero velocity is done twice, and the
latter one is superfluous.  Let's drop it.

Fixes: 0b5288f5fe63 ("ALSA: ump: Add legacy raw MIDI support")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/4683198a-84f6-4238-9e87-c70667d84523@kili.mountain
Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20230525083124.15277-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/core/ump_convert.c b/sound/core/ump_convert.c
index cb7c2f959a278449e61855fcbcc6e4af1d23dde9..164829d3e305519a44a23e9c8b85658bcb63870e 100644 (file)
--- a/sound/core/ump_convert.c
+++ b/sound/core/ump_convert.c
@@ -340,9 +340,6 @@ static int cvt_legacy_cmd_to_ump(struct snd_ump_endpoint *ump,
 
        switch (status) {
        case UMP_MSG_STATUS_NOTE_ON:
-               if (!buf[2])
-                       status = UMP_MSG_STATUS_NOTE_OFF;
-               fallthrough;
        case UMP_MSG_STATUS_NOTE_OFF:
                midi2->note.note = buf[1];
                midi2->note.velocity = upscale_7_to_16bit(buf[2]);