tty: srmcons: use 'buf' directly in srmcons_do_write()
authorJiri Slaby (SUSE) <jirislaby@kernel.org>
Tue, 21 Nov 2023 09:22:54 +0000 (10:22 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 25 Nov 2023 07:23:18 +0000 (07:23 +0000)
There is no need to have a separate iterator ('cur') through 'buf' in
srmcons_do_write(). 'buf' can be used directly which simplifies the code
a bit.

Signed-off-by: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Cc: Richard Henderson <richard.henderson@linaro.org>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Matt Turner <mattst88@gmail.com>
Cc: linux-alpha@vger.kernel.org
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Link: https://lore.kernel.org/r/20231121092258.9334-14-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/alpha/kernel/srmcons.c

index d6139dbae4ac9ff668da6c95d02abba01e87282b..b68c5af083cd1949fe0e30c3e4c4b4dde5ebc2d7 100644 (file)
@@ -94,24 +94,23 @@ srmcons_do_write(struct tty_port *port, const char *buf, int count)
        static char str_cr[1] = "\r";
        long c, remaining = count;
        srmcons_result result;
-       char *cur;
        int need_cr;
 
-       for (cur = (char *)buf; remaining > 0; ) {
+       while (remaining > 0) {
                need_cr = 0;
                /* 
                 * Break it up into reasonable size chunks to allow a chance
                 * for input to get in
                 */
                for (c = 0; c < min_t(long, 128L, remaining) && !need_cr; c++)
-                       if (cur[c] == '\n')
+                       if (buf[c] == '\n')
                                need_cr = 1;
                
                while (c > 0) {
-                       result.as_long = callback_puts(0, cur, c);
+                       result.as_long = callback_puts(0, buf, c);
                        c -= result.bits.c;
                        remaining -= result.bits.c;
-                       cur += result.bits.c;
+                       buf += result.bits.c;
 
                        /*
                         * Check for pending input iff a tty port was provided