media: i2c: mt9m114: Fix missing error unwind in probe()
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Tue, 3 Oct 2023 19:20:43 +0000 (22:20 +0300)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Thu, 12 Oct 2023 07:22:29 +0000 (09:22 +0200)
Two paths in the probe function return directly instead of jumping to
error handling. Fix them.

Fixes: 24d756e914fc ("media: i2c: Add driver for onsemi MT9M114 camera sensor")
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/i2c/mt9m114.c

index dae675e523901d001514700066633427fcf3fe63..ac19078ceda3f69e34e710624bc8dfb4b61c15cb 100644 (file)
@@ -2367,7 +2367,7 @@ static int mt9m114_probe(struct i2c_client *client)
 
        ret = mt9m114_clk_init(sensor);
        if (ret)
-               return ret;
+               goto error_ep_free;
 
        /*
         * Identify the sensor. The driver supports runtime PM, but needs to
@@ -2378,7 +2378,7 @@ static int mt9m114_probe(struct i2c_client *client)
        ret = mt9m114_power_on(sensor);
        if (ret < 0) {
                dev_err_probe(dev, ret, "Could not power on the device\n");
-               return ret;
+               goto error_ep_free;
        }
 
        ret = mt9m114_identify(sensor);