bcachefs: Fix an error path
authorKent Overstreet <kent.overstreet@gmail.com>
Wed, 2 Oct 2019 04:29:37 +0000 (00:29 -0400)
committerKent Overstreet <kent.overstreet@linux.dev>
Sun, 22 Oct 2023 21:08:28 +0000 (17:08 -0400)
It's possible to get -EIO in __btree_iter_traverse_all() after looping,
with orig_iter NULL.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/btree_iter.c

index 8e9164aee4093c5fe5da324895c28b9477e58cda..78bc82c7b9c33ac3b9bbfabd02a071f5db1d2923 100644 (file)
@@ -1010,8 +1010,11 @@ retry_all:
 
        if (unlikely(ret == -EIO)) {
                trans->error = true;
-               orig_iter->flags |= BTREE_ITER_ERROR;
-               orig_iter->l[orig_iter->level].b = BTREE_ITER_NO_NODE_ERROR;
+               if (orig_iter) {
+                       orig_iter->flags |= BTREE_ITER_ERROR;
+                       orig_iter->l[orig_iter->level].b =
+                               BTREE_ITER_NO_NODE_ERROR;
+               }
                goto out;
        }