perf stat: Display length strings of each run for --table option
authorJiri Olsa <jolsa@kernel.org>
Mon, 23 Apr 2018 09:08:22 +0000 (11:08 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 26 Apr 2018 12:30:27 +0000 (09:30 -0300)
Adding support to display visual aid 'length strings' to easily spot the
biggest difference in time table.

  $ perf stat -r 10 --table perf bench sched pipe
  ...

   Performance counter stats for './perf bench sched pipe' (5 runs):

             # Table of individual measurements:
             5.189 (-0.293) #
             5.189 (-0.294) #
             5.186 (-0.296) #
             5.663 (+0.181) ##
             6.186 (+0.703) ####

             # Final result:
             5.483 +- 0.198 seconds time elapsed  ( +-  3.62% )

Suggested-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180423090823.32309-9-jolsa@kernel.org
[ Updated 'perf stat --table' man page entry ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/Documentation/perf-stat.txt
tools/perf/builtin-stat.c

index 72a2414513bda97ef9dda53c65f9b3d6475dcb97..3a822f308e6d1a04f2a04433665985bb9c6a2e1d 100644 (file)
@@ -123,14 +123,14 @@ spreadsheets. Columns are separated by the string specified in SEP.
    Performance counter stats for 'perf bench sched pipe' (5 runs):
 
              # Table of individual measurements:
-             5.379 (-0.176)
-             5.243 (-0.311)
-             5.238 (-0.317)
-             5.536 (-0.019)
-             6.377 (+0.823)
+             5.189 (-0.293) #
+             5.189 (-0.294) #
+             5.186 (-0.296) #
+             5.663 (+0.181) ##
+             6.186 (+0.703) ####
 
              # Final result:
-             5.555 +- 0.213 seconds time elapsed  ( +-  3.83% )
+             5.483 +- 0.198 seconds time elapsed  ( +-  3.62% )
 
 -G name::
 --cgroup name::
index 72553937c010d855abc47daf1fe60cafced7d460..a4f662a462c66c2112db0a1947d21d5d97d2431e 100644 (file)
@@ -1790,9 +1790,15 @@ static void print_table(FILE *output, int precision, double avg)
 
        for (idx = 0; idx < run_count; idx++) {
                double run = (double) walltime_run[idx] / NSEC_PER_SEC;
+               int h, n = 1 + abs((int) (100.0 * (run - avg)/run) / 5);
 
-               fprintf(output, " %17.*f (%+.*f)\n",
+               fprintf(output, " %17.*f (%+.*f) ",
                        precision, run, precision, run - avg);
+
+               for (h = 0; h < n; h++)
+                       fprintf(output, "#");
+
+               fprintf(output, "\n");
        }
 
        fprintf(output, "\n%*s# Final result:\n", indent, "");