i386/kvm: add a comment explaining why .feat_names are commented out for Hyper-V...
authorVitaly Kuznetsov <vkuznets@redhat.com>
Fri, 21 Dec 2018 14:16:04 +0000 (15:16 +0100)
committerEduardo Habkost <ehabkost@redhat.com>
Mon, 14 Jan 2019 14:28:44 +0000 (12:28 -0200)
Hyper-V .feat_names are, unlike hardware features, commented out and it is
not obvious why we do that. Document the current status quo.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Message-Id: <20181221141604.16935-1-vkuznets@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
target/i386/cpu.c

index 3ece83696e007c7250c0e50a3d5633a1dfd5e0cc..2f5412592d30ea7a24810f3bf6a8c7d4b035a0f9 100644 (file)
@@ -929,6 +929,13 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
          */
         .no_autoenable_flags = ~0U,
     },
+    /*
+     * .feat_names are commented out for Hyper-V enlightenments because we
+     * don't want to have two different ways for enabling them on QEMU command
+     * line. Some features (e.g. "hyperv_time", "hyperv_vapic", ...) require
+     * enabling several feature bits simultaneously, exposing these bits
+     * individually may just confuse guests.
+     */
     [FEAT_HYPERV_EAX] = {
         .type = CPUID_FEATURE_WORD,
         .feat_names = {