irqchip/pruss-intc: Convert to platform_driver::remove_new() callback

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/071057cfdc0bc52c574f74156b410c0337adb69c.1703284359.git.u.kleine-koenig@pengutronix.de

diff --git a/drivers/irqchip/irq-pruss-intc.c b/drivers/irqchip/irq-pruss-intc.c
index 0f64ecb9b1f4e929d7002057f67f3d57239efcb1..060eb000e9d359ec54d59f4a31ad6b7be44dd8c3 100644 (file)
--- a/drivers/irqchip/irq-pruss-intc.c
+++ b/drivers/irqchip/irq-pruss-intc.c
@@ -599,7 +599,7 @@ fail_irq:
        return ret;
 }
 
-static int pruss_intc_remove(struct platform_device *pdev)
+static void pruss_intc_remove(struct platform_device *pdev)
 {
        struct pruss_intc *intc = platform_get_drvdata(pdev);
        u8 max_system_events = intc->soc_config->num_system_events;
@@ -616,8 +616,6 @@ static int pruss_intc_remove(struct platform_device *pdev)
                irq_dispose_mapping(irq_find_mapping(intc->domain, hwirq));
 
        irq_domain_remove(intc->domain);
-
-       return 0;
 }
 
 static const struct pruss_intc_match_data pruss_intc_data = {
@@ -645,12 +643,12 @@ MODULE_DEVICE_TABLE(of, pruss_intc_of_match);
 
 static struct platform_driver pruss_intc_driver = {
        .driver = {
-               .name = "pruss-intc",
-               .of_match_table = pruss_intc_of_match,
-               .suppress_bind_attrs = true,
+               .name                   = "pruss-intc",
+               .of_match_table         = pruss_intc_of_match,
+               .suppress_bind_attrs    = true,
        },
-       .probe  = pruss_intc_probe,
-       .remove = pruss_intc_remove,
+       .probe          = pruss_intc_probe,
+       .remove_new     = pruss_intc_remove,
 };
 module_platform_driver(pruss_intc_driver);