net: phy/pcs: Explicitly include correct DT includes
authorRob Herring <robh@kernel.org>
Mon, 24 Jul 2023 21:19:05 +0000 (15:19 -0600)
committerJakub Kicinski <kuba@kernel.org>
Thu, 27 Jul 2023 04:55:37 +0000 (21:55 -0700)
The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230724211905.805665-1-robh@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/pcs/pcs-rzn1-miic.c
drivers/net/phy/marvell-88x2222.c
drivers/net/phy/mediatek-ge-soc.c

index 323bec5e57f83e435c629e18fae23ef5b2d1528b..e5d642c67a2ca91814d7fb0989f46fb95a1ae6fa 100644 (file)
@@ -12,6 +12,7 @@
 #include <linux/of_platform.h>
 #include <linux/pcs-rzn1-miic.h>
 #include <linux/phylink.h>
+#include <linux/platform_device.h>
 #include <linux/pm_runtime.h>
 #include <dt-bindings/net/pcs-rzn1-miic.h>
 
index f83cae64585d598cc8e6f30aa6f0b3cbb0567df3..e3aa30dad2e63843dfa17e67103e4bf8dc2bb6cf 100644 (file)
@@ -14,7 +14,6 @@
 #include <linux/mdio.h>
 #include <linux/marvell_phy.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/of_gpio.h>
 #include <linux/sfp.h>
 #include <linux/netdevice.h>
index 95369171a7ba6f656daeba49f2e4f37c8195486a..da512fab0eb0b01c83e2befc1fbb922b5602ca99 100644 (file)
@@ -2,8 +2,6 @@
 #include <linux/bitfield.h>
 #include <linux/module.h>
 #include <linux/nvmem-consumer.h>
-#include <linux/of_address.h>
-#include <linux/of_platform.h>
 #include <linux/pinctrl/consumer.h>
 #include <linux/phy.h>