dmaengine: mv_xor_v2: use {lower,upper}_32_bits to configure HW descriptor address
authorHanna Hawa <hannah@marvell.com>
Tue, 24 Jul 2018 13:40:30 +0000 (16:40 +0300)
committerVinod Koul <vkoul@kernel.org>
Wed, 25 Jul 2018 12:23:22 +0000 (17:53 +0530)
>> drivers/dma/mv_xor_v2.c:647:36: sparse: constant 0xFFFF00000000 is so big it is long
   include/linux/device.h:678:13: sparse: undefined identifier '__builtin_mul_overflow'
   include/linux/device.h:678:13: sparse: call with no type!

Use lower_32_bits and upper_32_bits to set the hw_desq address, instead of
using constant.

Signed-off-by: Hanna Hawa <hannah@marvell.com>
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/mv_xor_v2.c

index d41d916f40fac1cc3b61aa046816666ff5caeb76..8dc0aa4d73ab839e2aa870547a5697d14d4fc95c 100644 (file)
@@ -642,9 +642,9 @@ static int mv_xor_v2_descq_init(struct mv_xor_v2_device *xor_dev)
               xor_dev->dma_base + MV_XOR_V2_DMA_DESQ_SIZE_OFF);
 
        /* write the DESQ address to the DMA enngine*/
-       writel(xor_dev->hw_desq & 0xFFFFFFFF,
+       writel(lower_32_bits(xor_dev->hw_desq),
               xor_dev->dma_base + MV_XOR_V2_DMA_DESQ_BALR_OFF);
-       writel((xor_dev->hw_desq & 0xFFFF00000000) >> 32,
+       writel(upper_32_bits(xor_dev->hw_desq),
               xor_dev->dma_base + MV_XOR_V2_DMA_DESQ_BAHR_OFF);
 
        /*