projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
fdabe57
)
scsi: advansys: Do not set message byte in SCSI status
author
Hannes Reinecke
<hare@suse.de>
Tue, 27 Apr 2021 08:30:37 +0000
(10:30 +0200)
committer
Martin K. Petersen
<martin.petersen@oracle.com>
Tue, 1 Jun 2021 02:48:24 +0000
(22:48 -0400)
The host byte in the SCSI status takes precedence during error recovery, so
there is no point in setting the message byte in addition to a host byte
which is not DID_OK.
Link:
https://lore.kernel.org/r/20210427083046.31620-32-hare@suse.de
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/advansys.c
patch
|
blob
|
history
diff --git
a/drivers/scsi/advansys.c
b/drivers/scsi/advansys.c
index 379ff1bcfdbe0a4739f449356b8f12a877808fe0..f3377e2ef5fb38ee0834ab5976891cd4b721c778 100644
(file)
--- a/
drivers/scsi/advansys.c
+++ b/
drivers/scsi/advansys.c
@@
-6728,14
+6728,12
@@
static void asc_isr_callback(ASC_DVC_VAR *asc_dvc_varp, ASC_QDONE_INFO *qdonep)
case QD_ABORTED_BY_HOST:
ASC_DBG(1, "QD_ABORTED_BY_HOST\n");
set_status_byte(scp, qdonep->d3.scsi_stat);
- set_msg_byte(scp, qdonep->d3.scsi_msg);
set_host_byte(scp, DID_ABORT);
break;
default:
ASC_DBG(1, "done_stat 0x%x\n", qdonep->d3.done_stat);
set_status_byte(scp, qdonep->d3.scsi_stat);
- set_msg_byte(scp, qdonep->d3.scsi_msg);
set_host_byte(scp, DID_ERROR);
break;
}