media: atomisp: Log an error on failing to alloc private-mem
authorHans de Goede <hdegoede@redhat.com>
Sun, 23 Oct 2022 20:16:09 +0000 (21:16 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 25 Nov 2022 08:19:03 +0000 (08:19 +0000)
I managed to trigger an atomisp_css_start() error by pushing my test
system towards an OOM situation, this resulted in the following errors:

atomisp-isp2 0000:00:03.0: alloc pages err...
atomisp-isp2 0000:00:03.0: hmm_bo_alloc_pages failed.
atomisp-isp2 0000:00:03.0: stream[0] start error.

But it is not entirely clear what the root cause of
the "alloc pages err..." error is. I suspect the root cause is
alloc_pages_bulk_array() failing. Add a log message to make
the root cause more clear if this is hit again.

Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/atomisp/pci/hmm/hmm_bo.c

index 465ba837f2ed80b2cdb8718ba4ec17c2a41269cc..91d47e7e9c45668ca631a1743e3f0ee2b8e787f8 100644 (file)
@@ -638,6 +638,7 @@ static int alloc_private_pages(struct hmm_buffer_object *bo)
        ret = alloc_pages_bulk_array(gfp, bo->pgnr, bo->pages);
        if (ret != bo->pgnr) {
                free_pages_bulk_array(ret, bo->pages);
+               dev_err(atomisp_dev, "alloc_pages_bulk_array() failed\n");
                return -ENOMEM;
        }