powerpc/process: Remove target specific __set_dabr()
authorChristophe Leroy <christophe.leroy@csgroup.eu>
Fri, 4 Dec 2020 10:12:51 +0000 (10:12 +0000)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 9 Dec 2020 06:01:40 +0000 (17:01 +1100)
__set_dabr() are simple functions that can be inline directly
inside set_dabr() and using IS_ENABLED() instead of #ifdef

Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/c10b263668e137236c71d76648b03cf2cd1ee66f.1607076733.git.christophe.leroy@csgroup.eu
arch/powerpc/kernel/process.c

index 96bb10d00d9c930ac3f1442bb508ac5e6ee57513..a66f435dabbfe93f58bfa5d3eabee06ff04bec06 100644 (file)
@@ -806,29 +806,6 @@ static void switch_hw_breakpoint(struct task_struct *new)
 #endif /* !CONFIG_HAVE_HW_BREAKPOINT */
 #endif /* CONFIG_PPC_ADV_DEBUG_REGS */
 
-#ifdef CONFIG_PPC_ADV_DEBUG_REGS
-static inline int __set_dabr(unsigned long dabr, unsigned long dabrx)
-{
-       mtspr(SPRN_DAC1, dabr);
-       if (IS_ENABLED(CONFIG_PPC_47x))
-               isync();
-       return 0;
-}
-#elif defined(CONFIG_PPC_BOOK3S)
-static inline int __set_dabr(unsigned long dabr, unsigned long dabrx)
-{
-       mtspr(SPRN_DABR, dabr);
-       if (cpu_has_feature(CPU_FTR_DABRX))
-               mtspr(SPRN_DABRX, dabrx);
-       return 0;
-}
-#else
-static inline int __set_dabr(unsigned long dabr, unsigned long dabrx)
-{
-       return -EINVAL;
-}
-#endif
-
 static inline int set_dabr(struct arch_hw_breakpoint *brk)
 {
        unsigned long dabr, dabrx;
@@ -839,7 +816,19 @@ static inline int set_dabr(struct arch_hw_breakpoint *brk)
        if (ppc_md.set_dabr)
                return ppc_md.set_dabr(dabr, dabrx);
 
-       return __set_dabr(dabr, dabrx);
+       if (IS_ENABLED(CONFIG_PPC_ADV_DEBUG_REGS)) {
+               mtspr(SPRN_DAC1, dabr);
+               if (IS_ENABLED(CONFIG_PPC_47x))
+                       isync();
+               return 0;
+       } else if (IS_ENABLED(CONFIG_PPC_BOOK3S)) {
+               mtspr(SPRN_DABR, dabr);
+               if (cpu_has_feature(CPU_FTR_DABRX))
+                       mtspr(SPRN_DABRX, dabrx);
+               return 0;
+       } else {
+               return -EINVAL;
+       }
 }
 
 static inline int set_breakpoint_8xx(struct arch_hw_breakpoint *brk)