asm-generic: remove extra type checking in acquire/release for non-SMP case
authorBaokun Li <libaokun1@huawei.com>
Wed, 24 Jan 2024 14:28:57 +0000 (22:28 +0800)
committerChristian Brauner <brauner@kernel.org>
Thu, 25 Jan 2024 16:23:51 +0000 (17:23 +0100)
If CONFIG_SMP is not enabled, the smp_load_acquire/smp_store_release is
implemented as READ_ONCE/READ_ONCE and barrier() and type checking.
READ_ONCE/READ_ONCE already checks the pointer type, and then checks it
more stringently outside, but the non-SMP case simply isn't relevant, so
remove the extra compiletime_assert_atomic_type() to avoid compilation
errors.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202401230837.TXro0PHi-lkp@intel.com/
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Baokun Li <libaokun1@huawei.com>
Link: https://lore.kernel.org/r/20240124142857.4146716-4-libaokun1@huawei.com
Signed-off-by: Christian Brauner <brauner@kernel.org>
include/asm-generic/barrier.h

index 961f4d88f9ef784c3c8fbafd6925579698a93d5f..0c0695763bea394aadf9ed26abd8fb3bedc714cf 100644 (file)
@@ -193,7 +193,6 @@ do {                                                                        \
 #ifndef smp_store_release
 #define smp_store_release(p, v)                                                \
 do {                                                                   \
-       compiletime_assert_atomic_type(*p);                             \
        barrier();                                                      \
        WRITE_ONCE(*p, v);                                              \
 } while (0)
@@ -203,7 +202,6 @@ do {                                                                        \
 #define smp_load_acquire(p)                                            \
 ({                                                                     \
        __unqual_scalar_typeof(*p) ___p1 = READ_ONCE(*p);               \
-       compiletime_assert_atomic_type(*p);                             \
        barrier();                                                      \
        (typeof(*p))___p1;                                              \
 })