irqchip/gic-v3-its: Simplify LPI_PENDBASE_SZ usage
authorMarc Zyngier <marc.zyngier@arm.com>
Tue, 17 Jul 2018 17:06:39 +0000 (18:06 +0100)
committerMarc Zyngier <marc.zyngier@arm.com>
Tue, 2 Oct 2018 09:37:27 +0000 (10:37 +0100)
LPI_PENDING_SZ is always used in conjunction with a max(), which doesn't
make much sense, since we're guaranteed that LPI_PENDING_SZ is already
aligned to 64K. Let's remove it.

Tested-by: Jeremy Linton <jeremy.linton@arm.com>
Tested-by: Bhupesh Sharma <bhsharma@redhat.com>
Tested-by: Lei Zhang <zhang.lei@jp.fujitsu.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
drivers/irqchip/irq-gic-v3-its.c

index c2df341ff6fafd83df6463669c9ad6a1ceac56c9..842760a0f893180f4f456885eb212e690a1baa8c 100644 (file)
@@ -1924,12 +1924,9 @@ static int its_alloc_collections(struct its_node *its)
 static struct page *its_allocate_pending_table(gfp_t gfp_flags)
 {
        struct page *pend_page;
-       /*
-        * The pending pages have to be at least 64kB aligned,
-        * hence the 'max(LPI_PENDBASE_SZ, SZ_64K)' below.
-        */
+
        pend_page = alloc_pages(gfp_flags | __GFP_ZERO,
-                               get_order(max_t(u32, LPI_PENDBASE_SZ, SZ_64K)));
+                               get_order(LPI_PENDBASE_SZ));
        if (!pend_page)
                return NULL;
 
@@ -1941,8 +1938,7 @@ static struct page *its_allocate_pending_table(gfp_t gfp_flags)
 
 static void its_free_pending_table(struct page *pt)
 {
-       free_pages((unsigned long)page_address(pt),
-                  get_order(max_t(u32, LPI_PENDBASE_SZ, SZ_64K)));
+       free_pages((unsigned long)page_address(pt), get_order(LPI_PENDBASE_SZ));
 }
 
 static void its_cpu_init_lpis(void)