ASoC: mediatek: Fix error handling
authorTang Bin <tangbin@cmss.chinamobile.com>
Wed, 6 May 2020 14:30:09 +0000 (22:30 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 6 May 2020 16:21:22 +0000 (17:21 +0100)
If the function platform_get_irq() failed, the negative value
returned will not be detected here. So fix error handling in
mt6797_afe_pcm_dev_probe(). And when get irq failed, the function
platform_get_irq() logs an error message, so remove redundant
message here.

Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Link: https://lore.kernel.org/r/20200506143009.13368-1-tangbin@cmss.chinamobile.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/mediatek/mt6797/mt6797-afe-pcm.c

index 7f930556d961c08e9142021263a8f285de80a165..7f3ac04b942592f238c4330b8c419dded85bec77 100644 (file)
@@ -807,10 +807,9 @@ static int mt6797_afe_pcm_dev_probe(struct platform_device *pdev)
 
        /* request irq */
        irq_id = platform_get_irq(pdev, 0);
-       if (!irq_id) {
-               dev_err(dev, "%pOFn no irq found\n", dev->of_node);
-               return -ENXIO;
-       }
+       if (irq_id < 0)
+               return irq_id;
+
        ret = devm_request_irq(dev, irq_id, mt6797_afe_irq_handler,
                               IRQF_TRIGGER_NONE, "asys-isr", (void *)afe);
        if (ret) {