mmc: tmio: do not print real IOMEM pointer
authorKrzysztof Kozlowski <krzk@kernel.org>
Mon, 16 Nov 2020 16:42:52 +0000 (17:42 +0100)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 17 Nov 2020 11:46:39 +0000 (12:46 +0100)
Printing kernel pointers is discouraged because they might leak kernel
memory layout.  This fixes smatch warning:

    drivers/mmc/host/tmio_mmc.c:177 tmio_mmc_probe() warn: argument 3 to %08lx specifier is cast from pointer

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20201116164252.44078-1-krzk@kernel.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/tmio_mmc.c

index d2d3b8df1bbe4ea65c6d62daf34d1661e70f0197..b55a29c53d9c3e76c01b9656d1cda42773492766 100644 (file)
@@ -174,8 +174,7 @@ static int tmio_mmc_probe(struct platform_device *pdev)
        if (ret)
                goto host_remove;
 
-       pr_info("%s at 0x%08lx irq %d\n", mmc_hostname(host->mmc),
-               (unsigned long)host->ctl, irq);
+       pr_info("%s at 0x%p irq %d\n", mmc_hostname(host->mmc), host->ctl, irq);
 
        return 0;