staging: rtl8188eu: Drop unnecessary NULL check after container_of
authorGuenter Roeck <linux@roeck-us.net>
Fri, 14 May 2021 16:55:57 +0000 (09:55 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 May 2021 15:46:07 +0000 (17:46 +0200)
The result of container_of() operations is never NULL unless the extracted
element is the first element of the embedded structure. This is not the
case here. The NULL check is therefore unnecessary and misleading.
Remove it.

This change was made automatically with the following Coccinelle script.

@@
type t;
identifier v;
statement s;
@@

<+...
(
  t v = container_of(...);
|
  v = container_of(...);
)
  ...
  when != v
- if (\( !v \| v == NULL \) ) s
...+>

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20210514165557.1384106-1-linux@roeck-us.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c

index fc991c8c16d2170238715f0d5170ffd47fa7f5be..b4d81d3a856ce5e886ac20cba0a080dfe9a673ce 100644 (file)
@@ -4038,9 +4038,6 @@ void free_mlme_ext_priv(struct mlme_ext_priv *pmlmeext)
 {
        struct adapter *padapter = container_of(pmlmeext, struct adapter, mlmeextpriv);
 
-       if (!padapter)
-               return;
-
        if (padapter->bDriverStopped) {
                del_timer_sync(&pmlmeext->survey_timer);
                del_timer_sync(&pmlmeext->link_timer);