drm/msm: only register 'kms' debug file if KMS is used
authorDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Mon, 9 Oct 2023 18:10:38 +0000 (21:10 +0300)
committerRob Clark <robdclark@chromium.org>
Mon, 9 Oct 2023 18:42:36 +0000 (11:42 -0700)
There is little point in having the empty debugfs file which always
returns -ENODEV. Change this file to be created only if KMS is actually
used.

Reviewed-by: Rob Clark <robdclark@gmail.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/561656/
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/msm_debugfs.c

index a0a936f80ae350c1633c5345ece5215f7960e579..06fc632fd6f9f5f894e8e5a853f6375c54a7f719 100644 (file)
@@ -314,8 +314,9 @@ void msm_debugfs_init(struct drm_minor *minor)
        debugfs_create_file("gpu", S_IRUSR, minor->debugfs_root,
                dev, &msm_gpu_fops);
 
-       debugfs_create_file("kms", S_IRUSR, minor->debugfs_root,
-               dev, &msm_kms_fops);
+       if (priv->kms)
+               debugfs_create_file("kms", S_IRUSR, minor->debugfs_root,
+                                   dev, &msm_kms_fops);
 
        debugfs_create_u32("hangcheck_period_ms", 0600, minor->debugfs_root,
                &priv->hangcheck_period);