PCI: Drop pci_device_probe() test of !pci_dev->driver
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 4 Oct 2021 12:59:26 +0000 (14:59 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 12 Oct 2021 22:37:15 +0000 (17:37 -0500)
When the device core calls the .probe() callback for a device, the device
is never bound, so pci_dev->driver is always NULL.

Remove the unnecessary test of !pci_dev->driver.

Link: https://lore.kernel.org/r/20211004125935.2300113-3-u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
drivers/pci/pci-driver.c

index 8fb6418c93e822be84bec29d09d1803739f9c8e1..50449ec622a3edcfdc250425fff2e3ad54d069c4 100644 (file)
@@ -397,7 +397,7 @@ static int __pci_device_probe(struct pci_driver *drv, struct pci_dev *pci_dev)
        const struct pci_device_id *id;
        int error = 0;
 
-       if (!pci_dev->driver && drv->probe) {
+       if (drv->probe) {
                error = -ENODEV;
 
                id = pci_match_device(drv, pci_dev);