projects
/
qemu.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
af325d3
)
using strncpy is *always* a bad idea
author
bellard
<bellard@c046a42c-6fe2-441c-8c8c-71466251a162>
Wed, 11 Jun 2008 09:44:44 +0000
(09:44 +0000)
committer
bellard
<bellard@c046a42c-6fe2-441c-8c8c-71466251a162>
Wed, 11 Jun 2008 09:44:44 +0000
(09:44 +0000)
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4727
c046a42c
-6fe2-441c-8c8c-
71466251a162
vl.c
patch
|
blob
|
history
diff --git
a/vl.c
b/vl.c
index 18ddcce1f96deb5487287211e9ddc16840b68013..671b7a41d98633d117e8609defe9b728eb6adc71 100644
(file)
--- a/
vl.c
+++ b/
vl.c
@@
-3394,8
+3394,7
@@
static CharDriverState *qemu_chr_open_tcp(const char *host_str,
#ifndef _WIN32
if (is_unix) {
char path[109];
- strncpy(path, uaddr.sun_path, 108);
- path[108] = 0;
+ pstrcpy(path, sizeof(path), uaddr.sun_path);
unlink(path);
} else
#endif
@@
-5075,7
+5074,7
@@
static int drive_init(struct drive_opt *arg, int snapshot,
}
if (get_param_value(buf, sizeof(buf), "if", str)) {
-
strncpy(devname, buf, sizeof(devname)
);
+
pstrcpy(devname, sizeof(devname), buf
);
if (!strcmp(buf, "ide")) {
type = IF_IDE;
max_devs = MAX_IDE_DEVS;