ASoC: Intel: Skylake: use DEVICE_ATTR_RO macro
authorYueHaibing <yuehaibing@huawei.com>
Mon, 24 May 2021 11:55:06 +0000 (19:55 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 2 Jun 2021 11:03:33 +0000 (12:03 +0100)
Use DEVICE_ATTR_RO() helper instead of plain DEVICE_ATTR(),
which makes the code a bit shorter and easier to read.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/20210524115506.35724-1-yuehaibing@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/skylake/skl-nhlt.c

index 87c891c462910ad987cda209cbf1385a54d42fdc..64226072f0ee258706210ac6a45b6b0c8a530f0e 100644 (file)
@@ -149,8 +149,8 @@ int skl_nhlt_update_topology_bin(struct skl_dev *skl)
        return 0;
 }
 
-static ssize_t skl_nhlt_platform_id_show(struct device *dev,
-                       struct device_attribute *attr, char *buf)
+static ssize_t platform_id_show(struct device *dev,
+                               struct device_attribute *attr, char *buf)
 {
        struct pci_dev *pci = to_pci_dev(dev);
        struct hdac_bus *bus = pci_get_drvdata(pci);
@@ -166,7 +166,7 @@ static ssize_t skl_nhlt_platform_id_show(struct device *dev,
        return sprintf(buf, "%s\n", platform_id);
 }
 
-static DEVICE_ATTR(platform_id, 0444, skl_nhlt_platform_id_show, NULL);
+static DEVICE_ATTR_RO(platform_id);
 
 int skl_nhlt_create_sysfs(struct skl_dev *skl)
 {