netfilter: nf_queue: remove excess nf_bridge variable
authorPavel Tikhomirov <ptikhomirov@virtuozzo.com>
Thu, 11 Jan 2024 15:06:38 +0000 (23:06 +0800)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 17 Jan 2024 11:02:48 +0000 (12:02 +0100)
We don't really need nf_bridge variable here. And nf_bridge_info_exists
is better replacement for nf_bridge_info_get in case we are only
checking for existence.

Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_queue.c

index 63d1516816b1fdaa570288c725cc5f721cde694d..3dfcb3ac5cb44043324ff5e0288770ed794e255b 100644 (file)
@@ -82,10 +82,8 @@ static void __nf_queue_entry_init_physdevs(struct nf_queue_entry *entry)
 {
 #if IS_ENABLED(CONFIG_BRIDGE_NETFILTER)
        const struct sk_buff *skb = entry->skb;
-       struct nf_bridge_info *nf_bridge;
 
-       nf_bridge = nf_bridge_info_get(skb);
-       if (nf_bridge) {
+       if (nf_bridge_info_exists(skb)) {
                entry->physin = nf_bridge_get_physindev(skb);
                entry->physout = nf_bridge_get_physoutdev(skb);
        } else {