can: usb_8dev: do not report txerr and rxerr during bus-off
authorVincent Mailhol <mailhol.vincent@wanadoo.fr>
Tue, 19 Jul 2022 14:35:47 +0000 (23:35 +0900)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Wed, 20 Jul 2022 07:26:50 +0000 (09:26 +0200)
During bus off, the error count is greater than 255 and can not fit in
a u8.

Fixes: 0024d8ad1639 ("can: usb_8dev: Add support for USB2CAN interface from 8 devices")
Link: https://lore.kernel.org/all/20220719143550.3681-10-mailhol.vincent@wanadoo.fr
Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/usb/usb_8dev.c

index f3363575bf32c1f775a5b09ca5487082fd60a2f3..4d38dc90472a8ac18d07c5c8480333fcc0b55b0f 100644 (file)
@@ -438,9 +438,10 @@ static void usb_8dev_rx_err_msg(struct usb_8dev_priv *priv,
 
        if (rx_errors)
                stats->rx_errors++;
-
-       cf->data[6] = txerr;
-       cf->data[7] = rxerr;
+       if (priv->can.state != CAN_STATE_BUS_OFF) {
+               cf->data[6] = txerr;
+               cf->data[7] = rxerr;
+       }
 
        priv->bec.txerr = txerr;
        priv->bec.rxerr = rxerr;