staging: vt6655: fix camelcase in ldBmThreshold
authorTommaso Merciai <tomm.merciai@gmail.com>
Tue, 5 Oct 2021 20:56:58 +0000 (22:56 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 10 Oct 2021 12:52:07 +0000 (14:52 +0200)
Replace camel case variable ldBmThreshold with snake case
variable dbm_threshold. ldBmThreshold is in hungarian notation, where
"l" is for long and "dbm" is for decibel-milliwatt (signal strenght).
This variable contain's signal strenght threshold in dbm.

References:
 - https://en.wikipedia.org/wiki/Hungarian_notation
 - https://www.rapidtables.com/electric/dBm.html

Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
Link: https://lore.kernel.org/r/20211005205702.14029-3-tomm.merciai@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6655/baseband.c
drivers/staging/vt6655/device.h
drivers/staging/vt6655/device_main.c

index 491cf4d8bc6c9165e01c4e1cd24b64e161e6ab8b..7ae6ae984e2d99c123101e23f1d58c2606a5692f 100644 (file)
@@ -2021,10 +2021,10 @@ bool bb_vt3253_init(struct vnt_private *priv)
                priv->abyBBVGA[1] = 0x0A;
                priv->abyBBVGA[2] = 0x0;
                priv->abyBBVGA[3] = 0x0;
-               priv->ldBmThreshold[0] = -70;
-               priv->ldBmThreshold[1] = -50;
-               priv->ldBmThreshold[2] = 0;
-               priv->ldBmThreshold[3] = 0;
+               priv->dbm_threshold[0] = -70;
+               priv->dbm_threshold[1] = -50;
+               priv->dbm_threshold[2] = 0;
+               priv->dbm_threshold[3] = 0;
        } else if ((by_rf_type == RF_AIROHA) || (by_rf_type == RF_AL2230S)) {
                for (ii = 0; ii < CB_VT3253B0_INIT_FOR_AIROHA2230; ii++)
                        result &= bb_write_embedded(priv,
@@ -2039,10 +2039,10 @@ bool bb_vt3253_init(struct vnt_private *priv)
                priv->abyBBVGA[1] = 0x10;
                priv->abyBBVGA[2] = 0x0;
                priv->abyBBVGA[3] = 0x0;
-               priv->ldBmThreshold[0] = -70;
-               priv->ldBmThreshold[1] = -48;
-               priv->ldBmThreshold[2] = 0;
-               priv->ldBmThreshold[3] = 0;
+               priv->dbm_threshold[0] = -70;
+               priv->dbm_threshold[1] = -48;
+               priv->dbm_threshold[2] = 0;
+               priv->dbm_threshold[3] = 0;
        } else if (by_rf_type == RF_UW2451) {
                for (ii = 0; ii < CB_VT3253B0_INIT_FOR_UW2451; ii++)
                        result &= bb_write_embedded(priv,
@@ -2061,10 +2061,10 @@ bool bb_vt3253_init(struct vnt_private *priv)
                priv->abyBBVGA[1] = 0x0A;
                priv->abyBBVGA[2] = 0x0;
                priv->abyBBVGA[3] = 0x0;
-               priv->ldBmThreshold[0] = -60;
-               priv->ldBmThreshold[1] = -50;
-               priv->ldBmThreshold[2] = 0;
-               priv->ldBmThreshold[3] = 0;
+               priv->dbm_threshold[0] = -60;
+               priv->dbm_threshold[1] = -50;
+               priv->dbm_threshold[2] = 0;
+               priv->dbm_threshold[3] = 0;
        } else if (by_rf_type == RF_UW2452) {
                for (ii = 0; ii < CB_VT3253B0_INIT_FOR_UW2451; ii++)
                        result &= bb_write_embedded(priv,
@@ -2107,10 +2107,10 @@ bool bb_vt3253_init(struct vnt_private *priv)
                priv->abyBBVGA[1] = 0x0A;
                priv->abyBBVGA[2] = 0x0;
                priv->abyBBVGA[3] = 0x0;
-               priv->ldBmThreshold[0] = -60;
-               priv->ldBmThreshold[1] = -50;
-               priv->ldBmThreshold[2] = 0;
-               priv->ldBmThreshold[3] = 0;
+               priv->dbm_threshold[0] = -60;
+               priv->dbm_threshold[1] = -50;
+               priv->dbm_threshold[2] = 0;
+               priv->dbm_threshold[3] = 0;
                /* }} RobertYu */
 
        } else if (by_rf_type == RF_VT3226) {
@@ -2127,10 +2127,10 @@ bool bb_vt3253_init(struct vnt_private *priv)
                priv->abyBBVGA[1] = 0x10;
                priv->abyBBVGA[2] = 0x0;
                priv->abyBBVGA[3] = 0x0;
-               priv->ldBmThreshold[0] = -70;
-               priv->ldBmThreshold[1] = -48;
-               priv->ldBmThreshold[2] = 0;
-               priv->ldBmThreshold[3] = 0;
+               priv->dbm_threshold[0] = -70;
+               priv->dbm_threshold[1] = -48;
+               priv->dbm_threshold[2] = 0;
+               priv->dbm_threshold[3] = 0;
                /* Fix VT3226 DFC system timing issue */
                MACvSetRFLE_LatchBase(iobase);
                /* {{ RobertYu: 20050104 */
@@ -2161,10 +2161,10 @@ bool bb_vt3253_init(struct vnt_private *priv)
                priv->abyBBVGA[1] = 0x10;
                priv->abyBBVGA[2] = 0x0;
                priv->abyBBVGA[3] = 0x0;
-               priv->ldBmThreshold[0] = -70;
-               priv->ldBmThreshold[1] = -48;
-               priv->ldBmThreshold[2] = 0;
-               priv->ldBmThreshold[3] = 0;
+               priv->dbm_threshold[0] = -70;
+               priv->dbm_threshold[1] = -48;
+               priv->dbm_threshold[2] = 0;
+               priv->dbm_threshold[3] = 0;
                /* }} RobertYu */
        } else {
                /* No VGA Table now */
index 49e3d09480f2c8f3cf6e8b4041bcbc119263c2cc..307a36222c78aba9a551815e8f0e83f103798a1d 100644 (file)
@@ -253,7 +253,7 @@ struct vnt_private {
        unsigned char byBBVGANew;
        unsigned char byBBVGACurrent;
        unsigned char abyBBVGA[BB_VGA_LEVEL];
-       long                    ldBmThreshold[BB_VGA_LEVEL];
+       long                    dbm_threshold[BB_VGA_LEVEL];
 
        unsigned char byBBPreEDRSSI;
        unsigned char byBBPreEDIndex;
index 52c2a6651bc9941f200740656d40afee56ed9c0f..ff6c59e198a4a88e618b95e8bbf83d855283bc66 100644 (file)
@@ -986,7 +986,7 @@ static void vnt_check_bb_vga(struct vnt_private *priv)
        RFvRSSITodBm(priv, (u8)priv->uCurrRSSI, &dbm);
 
        for (i = 0; i < BB_VGA_LEVEL; i++) {
-               if (dbm < priv->ldBmThreshold[i]) {
+               if (dbm < priv->dbm_threshold[i]) {
                        priv->byBBVGANew = priv->abyBBVGA[i];
                        break;
                }