io_uring: drop exec checks from io_req_task_submit
authorPavel Begunkov <asml.silence@gmail.com>
Mon, 9 Aug 2021 12:04:19 +0000 (13:04 +0100)
committerJens Axboe <axboe@kernel.dk>
Mon, 23 Aug 2021 19:08:06 +0000 (13:08 -0600)
In case of on-exec io_uring cancellations, tasks already wait for all
submitted requests to get completed/cancelled, so we don't need to check
for ->in_execve separately.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/be8707049f10df9d20ca03dc4ca3316239b5e8e0.1628471125.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c

index 8cdcd645f3d834945686c2b1222fc17da1624fd2..cf75de0d74d2868d3f8eed1e2969e8830bbc2447 100644 (file)
@@ -2046,7 +2046,7 @@ static void io_req_task_submit(struct io_kiocb *req)
 
        /* ctx stays valid until unlock, even if we drop all ours ctx->refs */
        mutex_lock(&ctx->uring_lock);
-       if (!(req->task->flags & PF_EXITING) && !req->task->in_execve)
+       if (likely(!(req->task->flags & PF_EXITING)))
                __io_queue_sqe(req);
        else
                io_req_complete_failed(req, -EFAULT);