staging: rtl8188eu: use safe iterator in rtw_free_xmitframe_queue

Use list_for_each_entry_safe, we may delete list items while iterating
over the list.

Fixes: 23017c8842d2 ("staging: rtl8188eu: Use list iterators and helpers")
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20210517201826.25150-6-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c
index 3763d188b8922f6a0bca4111cb95aafaa676a190..dcc29a74612d284b4ea7d6e34c630b53e66d916f 100644 (file)
--- a/drivers/staging/rtl8188eu/core/rtw_xmit.c
+++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c
@@ -1329,17 +1329,15 @@ exit:
 
 void rtw_free_xmitframe_queue(struct xmit_priv *pxmitpriv, struct __queue *pframequeue)
 {
-       struct list_head *plist, *phead;
-       struct  xmit_frame      *pxmitframe;
+       struct list_head *phead;
+       struct  xmit_frame      *pxmitframe, *temp;
 
        spin_lock_bh(&pframequeue->lock);
 
        phead = get_list_head(pframequeue);
-       list_for_each(plist, phead) {
-               pxmitframe = list_entry(plist, struct xmit_frame, list);
-
+       list_for_each_entry_safe(pxmitframe, temp, phead, list)
                rtw_free_xmitframe(pxmitpriv, pxmitframe);
-       }
+
        spin_unlock_bh(&pframequeue->lock);
 }