net: pcs: lynx: no need to read LPA in lynx_pcs_get_state_2500basex()
authorVladimir Oltean <vladimir.oltean@nxp.com>
Mon, 13 May 2024 11:53:45 +0000 (14:53 +0300)
committerJakub Kicinski <kuba@kernel.org>
Mon, 13 May 2024 23:37:18 +0000 (16:37 -0700)
Nothing useful is done with the LPA variable in lynx_pcs_get_state_2500basex(),
we can just remove the read.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20240513115345.2452799-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/pcs/pcs-lynx.c

index 853b8c138718e3dadc84803d69c96943dfbf8298..b79aedad855be58df91ea936968c84917472f142 100644 (file)
@@ -61,11 +61,10 @@ static void lynx_pcs_get_state_usxgmii(struct mdio_device *pcs,
 static void lynx_pcs_get_state_2500basex(struct mdio_device *pcs,
                                         struct phylink_link_state *state)
 {
-       int bmsr, lpa;
+       int bmsr;
 
        bmsr = mdiodev_read(pcs, MII_BMSR);
-       lpa = mdiodev_read(pcs, MII_LPA);
-       if (bmsr < 0 || lpa < 0) {
+       if (bmsr < 0) {
                state->link = false;
                return;
        }