HID: i2c-hid: show the error when failing to fetch the HID descriptor
authorCoiby Xu <coiby.xu@gmail.com>
Wed, 21 Oct 2020 14:33:05 +0000 (22:33 +0800)
committerJiri Kosina <jkosina@suse.cz>
Thu, 29 Oct 2020 15:11:10 +0000 (16:11 +0100)
i2c_hid_probe() should notify the user of the error of failing to fetch the HID
Descriptor instead of silently exiting.

Link: https://forum.manjaro.org/t/elan-touchpad-working-in-live-but-not-in-native-os/31860/55
Cc: Barnabás Pőcze <pobrn@protonmail.com>
Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/i2c-hid/i2c-hid-core.c

index 786e3e9af1c9e8e098fc4f606b6a7d2191a073c6..577d324be16d06011d85aa7f7a3b39806bed862c 100644 (file)
@@ -1099,8 +1099,11 @@ static int i2c_hid_probe(struct i2c_client *client,
        }
 
        ret = i2c_hid_fetch_hid_descriptor(ihid);
-       if (ret < 0)
+       if (ret < 0) {
+               dev_err(&client->dev,
+                       "Failed to fetch the HID Descriptor\n");
                goto err_regulator;
+       }
 
        ret = i2c_hid_init_irq(client);
        if (ret < 0)