serdev: ttyport: do not used keyed wakeup in write_wakeup
authorJohan Hovold <johan@kernel.org>
Mon, 18 Dec 2017 11:00:19 +0000 (12:00 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 18 Dec 2017 11:25:14 +0000 (12:25 +0100)
Serdev does not use the file abstraction and specifically there will
never be anyone polling a file descriptor for POLLOUT events.

Just use plain wake_up_interruptible() in the write_wakeup callback and
document why it's there.

Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serdev/serdev-ttyport.c

index c2629ab1bbcf7f832223b22d6b0b3f93a2b12db4..a5abb05be67d0273f49d0ede83dde3c329ad8db4 100644 (file)
@@ -59,7 +59,8 @@ static void ttyport_write_wakeup(struct tty_port *port)
            test_bit(SERPORT_ACTIVE, &serport->flags))
                serdev_controller_write_wakeup(ctrl);
 
-       wake_up_interruptible_poll(&tty->write_wait, POLLOUT);
+       /* Wake up any tty_wait_until_sent() */
+       wake_up_interruptible(&tty->write_wait);
 
        tty_kref_put(tty);
 }