bus: ti-sysc: Fix sleeping function called from invalid context for RTC quirk
authorTony Lindgren <tony@atomide.com>
Thu, 2 Jul 2020 17:41:02 +0000 (10:41 -0700)
committerTony Lindgren <tony@atomide.com>
Thu, 2 Jul 2020 17:47:43 +0000 (10:47 -0700)
With CONFIG_DEBUG_ATOMIC_SLEEP enabled we can see the following with RTC probe:

BUG: sleeping function called from invalid context at drivers/bus/ti-sysc.c:1736
...
(sysc_quirk_rtc) from [<c060d01c>] (sysc_write_sysconfig+0x1c/0x60)
(sysc_write_sysconfig) from [<c060d9f4>] (sysc_enable_module+0x11c/0x274)
(sysc_enable_module) from [<c060f37c>] (sysc_probe+0xe9c/0x1380)
(sysc_probe) from [<c06e9384>] (platform_drv_probe+0x48/0x98)

Fixes: e8639e1c986a ("bus: ti-sysc: Handle module unlock quirk needed for some RTC")
Signed-off-by: Tony Lindgren <tony@atomide.com>
drivers/bus/ti-sysc.c

index 2ce8612f13a9a8e9887a0ba08630f7b8c58022ee..f5a533ce97f962204dfbc52534d792923a33cbed 100644 (file)
@@ -1727,8 +1727,8 @@ static void sysc_quirk_rtc(struct sysc *ddata, bool lock)
 
        local_irq_save(flags);
        /* RTC_STATUS BUSY bit may stay active for 1/32768 seconds (~30 usec) */
-       error = readl_poll_timeout(ddata->module_va + 0x44, val,
-                                  !(val & BIT(0)), 100, 50);
+       error = readl_poll_timeout_atomic(ddata->module_va + 0x44, val,
+                                         !(val & BIT(0)), 100, 50);
        if (error)
                dev_warn(ddata->dev, "rtc busy timeout\n");
        /* Now we have ~15 microseconds to read/write various registers */