iio: adc: twl6030-gpadc: use 'time_left' variable with wait_for_completion_interrupti...
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Mon, 29 Apr 2024 11:33:10 +0000 (13:33 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 29 Apr 2024 20:06:18 +0000 (21:06 +0100)
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_interruptible_timeout() causing patterns like:

timeout = wait_for_completion_interruptible_timeout(...)
if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20240429113313.68359-8-wsa+renesas@sang-engineering.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/twl6030-gpadc.c

index 78bf55438b2c672428744b31f14b5259885b2c1f..6a3db2bce460903dd6f242820055022b090fa1f6 100644 (file)
@@ -519,7 +519,7 @@ static int twl6030_gpadc_read_raw(struct iio_dev *indio_dev,
 {
        struct twl6030_gpadc_data *gpadc = iio_priv(indio_dev);
        int ret;
-       long timeout;
+       long time_left;
 
        mutex_lock(&gpadc->lock);
 
@@ -529,12 +529,12 @@ static int twl6030_gpadc_read_raw(struct iio_dev *indio_dev,
                goto err;
        }
        /* wait for conversion to complete */
-       timeout = wait_for_completion_interruptible_timeout(
+       time_left = wait_for_completion_interruptible_timeout(
                                &gpadc->irq_complete, msecs_to_jiffies(5000));
-       if (timeout == 0) {
+       if (time_left == 0) {
                ret = -ETIMEDOUT;
                goto err;
-       } else if (timeout < 0) {
+       } else if (time_left < 0) {
                ret = -EINTR;
                goto err;
        }