drm/amdgpu: remove misleading amdgpu_pmops_runtime_idle() comment
authorBjorn Helgaas <bhelgaas@google.com>
Thu, 29 Feb 2024 18:11:06 +0000 (12:11 -0600)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 1 Mar 2024 01:35:39 +0000 (20:35 -0500)
After 4020c2280233 ("drm/amdgpu: don't runtime suspend if there are
displays attached (v3)"), "ret" is unconditionally set later before being
used, so there's point in initializing it and the associated comment is no
longer meaningful.

Remove the comment and the unnecessary initialization.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

index 8e1299fe2c54a809761301c15e8bcbe918986bac..6acffedf648c8d8452ffd21ebbd3156573c91c38 100644 (file)
@@ -2791,8 +2791,7 @@ static int amdgpu_pmops_runtime_idle(struct device *dev)
 {
        struct drm_device *drm_dev = dev_get_drvdata(dev);
        struct amdgpu_device *adev = drm_to_adev(drm_dev);
-       /* we don't want the main rpm_idle to call suspend - we want to autosuspend */
-       int ret = 1;
+       int ret;
 
        if (adev->pm.rpm_mode == AMDGPU_RUNPM_NONE) {
                pm_runtime_forbid(dev);