staging: r8188eu: convert/remove DBG_88E calls in core/rtw_cmd.c
authorPhillip Potter <phil@philpotter.co.uk>
Mon, 6 Dec 2021 23:49:52 +0000 (23:49 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 7 Dec 2021 10:12:22 +0000 (11:12 +0100)
Convert two DBG_88E calls within core/rtw_cmd.c to netdev_dbg calls, and
remove three commented DBG_88E calls. Considering the original driver
author commented them, it seems better to delete these three than
convert.

Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20211206234952.1238-3-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_cmd.c

index d0a61331b8839e6575d3d36c9183bc262d5e4053..ace3a6342e01cb05dd64b816bb25656c52aef3a3 100644 (file)
@@ -255,8 +255,9 @@ int rtw_cmd_thread(void *context)
 _next:
                if (padapter->bDriverStopped ||
                    padapter->bSurpriseRemoved) {
-                       DBG_88E("%s: DriverStopped(%d) SurpriseRemoved(%d) break at line %d\n",
-                               __func__, padapter->bDriverStopped, padapter->bSurpriseRemoved, __LINE__);
+                       netdev_dbg(padapter->pnetdev,
+                                  "DriverStopped(%d) SurpriseRemoved(%d) break\n",
+                                  padapter->bDriverStopped, padapter->bSurpriseRemoved);
                        break;
                }
 
@@ -316,8 +317,6 @@ post_process:
                if (!pcmd)
                        break;
 
-               /* DBG_88E("%s: leaving... drop cmdcode:%u\n", __func__, pcmd->cmdcode); */
-
                rtw_free_cmd_obj(pcmd);
        } while (1);
 
@@ -579,7 +578,7 @@ u8 rtw_joinbss_cmd(struct adapter  *padapter, struct wlan_network *pnetwork)
        else
                padapter->pwrctrlpriv.smart_ps = padapter->registrypriv.smart_ps;
 
-       DBG_88E("%s: smart_ps =%d\n", __func__, padapter->pwrctrlpriv.smart_ps);
+       netdev_dbg(padapter->pnetdev, "smart_ps = %d\n", padapter->pwrctrlpriv.smart_ps);
 
        pcmd->cmdsz = get_wlan_bssid_ex_sz(psecnetwork);/* get cmdsz before endian conversion */
 
@@ -800,8 +799,6 @@ u8 rtw_addbareq_cmd(struct adapter *padapter, u8 tid, u8 *addr)
 
        init_h2fwcmd_w_parm_no_rsp(ph2c, paddbareq_parm, GEN_CMD_CODE(_AddBAReq));
 
-       /* DBG_88E("rtw_addbareq_cmd, tid =%d\n", tid); */
-
        /* rtw_enqueue_cmd(pcmdpriv, ph2c); */
        res = rtw_enqueue_cmd(pcmdpriv, ph2c);
 
@@ -1003,7 +1000,6 @@ static void lps_ctrl_wk_hdl(struct adapter *padapter, u8 lps_ctrl_type)
                SetHwReg8188EU(padapter, HW_VAR_H2C_FW_JOINBSSRPT, (u8 *)(&mstatus));
                break;
        case LPS_CTRL_SPECIAL_PACKET:
-               /* DBG_88E("LPS_CTRL_SPECIAL_PACKET\n"); */
                pwrpriv->DelayLPSLastTimeStamp = jiffies;
                LPS_Leave(padapter);
                break;