hw/ide/ahci: Remove SysbusAHCIState::num_ports field
authorPhilippe Mathieu-Daudé <philmd@linaro.org>
Tue, 13 Feb 2024 05:26:06 +0000 (06:26 +0100)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Thu, 15 Feb 2024 15:58:46 +0000 (16:58 +0100)
No need to duplicate AHCIState::ports, directly access it.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20240213081201.78951-9-philmd@linaro.org>

hw/ide/ahci.c
include/hw/ide/ahci.h

index 33f7e83687c5b08e53f5d7f3ff0269afd0c0bf8d..041cc87c11912171ec91463023b6cc6eb4ff4ac7 100644 (file)
@@ -1862,12 +1862,11 @@ static void sysbus_ahci_realize(DeviceState *dev, Error **errp)
 {
     SysbusAHCIState *s = SYSBUS_AHCI(dev);
 
-    s->ahci.ports = s->num_ports;
     ahci_realize(&s->ahci, dev, &address_space_memory);
 }
 
 static Property sysbus_ahci_properties[] = {
-    DEFINE_PROP_UINT32("num-ports", SysbusAHCIState, num_ports, 1),
+    DEFINE_PROP_UINT32("num-ports", SysbusAHCIState, ahci.ports, 1),
     DEFINE_PROP_END_OF_LIST(),
 };
 
index 604d3a09941acaa628ce7e8d8bf6d0d92d4b5fe2..c0b10c2bb4f481880c2ff307a10ead22d545e85c 100644 (file)
@@ -63,7 +63,6 @@ struct SysbusAHCIState {
     /*< public >*/
 
     AHCIState ahci;
-    uint32_t num_ports;
 };
 
 #define TYPE_ALLWINNER_AHCI "allwinner-ahci"