drivers: hv: vmbus: Fix checkpatch SPLIT_STRING
authorMatheus Castello <matheus@castello.eng.br>
Wed, 25 Nov 2020 03:29:26 +0000 (00:29 -0300)
committerWei Liu <wei.liu@kernel.org>
Wed, 2 Dec 2020 11:54:19 +0000 (11:54 +0000)
Checkpatch emits WARNING: quoted string split across lines.
To keep the code clean and with the 80 column length indentation the
check and registration code for kmsg_dump_register has been transferred
to a new function hv_kmsg_dump_register.

Signed-off-by: Matheus Castello <matheus@castello.eng.br>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Link: https://lore.kernel.org/r/20201125032926.17002-1-matheus@castello.eng.br
Signed-off-by: Wei Liu <wei.liu@kernel.org>
drivers/hv/vmbus_drv.c

index 0a2711aa63a159bb0cf46a4f6a2cde14722be418..502f8cd95f6d46cb6db5923ba877612f886d4a7a 100644 (file)
@@ -1387,6 +1387,24 @@ static struct kmsg_dumper hv_kmsg_dumper = {
        .dump = hv_kmsg_dump,
 };
 
+static void hv_kmsg_dump_register(void)
+{
+       int ret;
+
+       hv_panic_page = hv_alloc_hyperv_zeroed_page();
+       if (!hv_panic_page) {
+               pr_err("Hyper-V: panic message page memory allocation failed\n");
+               return;
+       }
+
+       ret = kmsg_dump_register(&hv_kmsg_dumper);
+       if (ret) {
+               pr_err("Hyper-V: kmsg dump register error 0x%x\n", ret);
+               hv_free_hyperv_page((unsigned long)hv_panic_page);
+               hv_panic_page = NULL;
+       }
+}
+
 static struct ctl_table_header *hv_ctl_table_hdr;
 
 /*
@@ -1477,21 +1495,8 @@ static int vmbus_bus_init(void)
                 * capability is supported by the hypervisor.
                 */
                hv_get_crash_ctl(hyperv_crash_ctl);
-               if (hyperv_crash_ctl & HV_CRASH_CTL_CRASH_NOTIFY_MSG) {
-                       hv_panic_page = (void *)hv_alloc_hyperv_zeroed_page();
-                       if (hv_panic_page) {
-                               ret = kmsg_dump_register(&hv_kmsg_dumper);
-                               if (ret) {
-                                       pr_err("Hyper-V: kmsg dump register "
-                                               "error 0x%x\n", ret);
-                                       hv_free_hyperv_page(
-                                           (unsigned long)hv_panic_page);
-                                       hv_panic_page = NULL;
-                               }
-                       } else
-                               pr_err("Hyper-V: panic message page memory "
-                                       "allocation failed");
-               }
+               if (hyperv_crash_ctl & HV_CRASH_CTL_CRASH_NOTIFY_MSG)
+                       hv_kmsg_dump_register();
 
                register_die_notifier(&hyperv_die_block);
        }