drm/i915/gtt: stop caching the scratch page
authorMatthew Auld <matthew.auld@intel.com>
Thu, 28 Oct 2021 09:26:38 +0000 (10:26 +0100)
committerMatthew Auld <matthew.auld@intel.com>
Fri, 29 Oct 2021 08:03:42 +0000 (09:03 +0100)
Normal users shouldn't be hitting this, likely this would indicate a
userspace bug. So don't bother caching, which should be safe now that we
manually flush the page.

Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ramalingam C <ramalingam.c@intel.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211028092638.3142258-2-matthew.auld@intel.com
drivers/gpu/drm/i915/gt/gen8_ppgtt.c

index 8af2f709571c154d7610149de4dfb25cad5e8b91..9966e9dc5218c2db2b00acec7028731d2c5f99b4 100644 (file)
@@ -651,7 +651,7 @@ static int gen8_init_scratch(struct i915_address_space *vm)
 
        vm->scratch[0]->encode =
                gen8_pte_encode(px_dma(vm->scratch[0]),
-                               I915_CACHE_LLC, pte_flags);
+                               I915_CACHE_NONE, pte_flags);
 
        for (i = 1; i <= vm->top; i++) {
                struct drm_i915_gem_object *obj;
@@ -667,7 +667,7 @@ static int gen8_init_scratch(struct i915_address_space *vm)
                }
 
                fill_px(obj, vm->scratch[i - 1]->encode);
-               obj->encode = gen8_pde_encode(px_dma(obj), I915_CACHE_LLC);
+               obj->encode = gen8_pde_encode(px_dma(obj), I915_CACHE_NONE);
 
                vm->scratch[i] = obj;
        }