spi: sprd-adi: silence an uninitialized variable warning
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 22 Sep 2017 20:48:08 +0000 (23:48 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 25 Sep 2017 16:09:44 +0000 (17:09 +0100)
If of_get_property() fails then "size" is uninitialized and it leads to
a static checker warning:

    drivers/spi/spi-sprd-adi.c:288 sprd_adi_hw_init()
    error: uninitialized symbol 'size'.

We can silence the warning by re-arranging the order of these checks.
It obviously doesn't affect runtime at all.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-sprd-adi.c

index bff6ef1caad77bed33fe1f5a06d4fde6523ee7ed..1324463244d373dd44e03a3953a876eea46ee0a0 100644 (file)
@@ -285,7 +285,7 @@ static void sprd_adi_hw_init(struct sprd_adi *sadi)
 
        /* Set hardware channels setting */
        list = of_get_property(np, "sprd,hw-channels", &size);
-       if (!size || !list) {
+       if (!list || !size) {
                dev_info(sadi->dev, "no hw channels setting in node\n");
                return;
        }